[Security Solution] Default Risk score slide bar values are overlaid on Rule Creation page (#161456) #172677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on Rule Creation page (elastic#161456)
e40pud
added
release_note:fix
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
e40pud
added
the
backport:prev-minor
nikitaindik
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Thanks for the fix Zhenia! Tested locally - the bug does not reproduce. Approved.
I wonder what would be the best way to track the status of the EUI issue, so that we can remove the workaround once it's fixed on their end?
...ck/plugins/security_solution/public/detections/components/rules/risk_score_mapping/index.tsx
Outdated
Show resolved
Hide resolved
e40pud
commented
Dec 12, 2023
...ck/plugins/security_solution/public/detections/components/rules/risk_score_mapping/index.tsx
Outdated
Show resolved
Hide resolved
…rules/risk_score_mapping/index.tsx Typo
We will have to monitor the status of that ticket to do that. I am part of the notification list there, so as soon as I see some progress and fix for ti I will remove this workaround in our codebase. |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @e40pud |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 12, 2023
…on Rule Creation page (elastic#161456) (elastic#172677) ## Summary Addresses elastic#161456 These changes do workaround to display EuiRange component which is broken due to memoization (see more details in elastic#160561 and elastic/eui#6846) The fix is to forcibly remove/add EuiRange component on About step activation. Before the fix: <img width="435" alt="Screenshot 2023-07-12 at 19 06 01" src="https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f"> After the fix: <img width="426" alt="Screenshot 2023-07-12 at 19 05 46" src="https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7"> (cherry picked from commit 28d18e8)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 12, 2023
…erlaid on Rule Creation page (#161456) (#172677) (#173140) # Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution] Default Risk score slide bar values are overlaid on Rule Creation page (#161456) (#172677)](#172677) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-12T10:29:50Z","message":"[Security Solution] Default Risk score slide bar values are overlaid on Rule Creation page (#161456) (#172677)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/kibana/issues/161456\r\n\r\nThese changes do workaround to display EuiRange component which is\r\nbroken due to memoization (see more details in\r\nhttps://github.com//issues/160561 and\r\nhttps://github.com/elastic/eui/issues/6846)\r\n\r\nThe fix is to forcibly remove/add EuiRange component on About step\r\nactivation.\r\n\r\nBefore the fix:\r\n\r\n<img width=\"435\" alt=\"Screenshot 2023-07-12 at 19 06 01\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f\">\r\n\r\nAfter the fix:\r\n\r\n<img width=\"426\" alt=\"Screenshot 2023-07-12 at 19 05 46\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7\">","sha":"28d18e89fba53cc1ca5d46bd0b5d0964d0a7c75a","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team: SecuritySolution","backport:prev-minor","Team:Detection Engine","v8.13.0"],"number":172677,"url":"https://github.com/elastic/kibana/pull/172677","mergeCommit":{"message":"[Security Solution] Default Risk score slide bar values are overlaid on Rule Creation page (#161456) (#172677)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/kibana/issues/161456\r\n\r\nThese changes do workaround to display EuiRange component which is\r\nbroken due to memoization (see more details in\r\nhttps://github.com//issues/160561 and\r\nhttps://github.com/elastic/eui/issues/6846)\r\n\r\nThe fix is to forcibly remove/add EuiRange component on About step\r\nactivation.\r\n\r\nBefore the fix:\r\n\r\n<img width=\"435\" alt=\"Screenshot 2023-07-12 at 19 06 01\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f\">\r\n\r\nAfter the fix:\r\n\r\n<img width=\"426\" alt=\"Screenshot 2023-07-12 at 19 05 46\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7\">","sha":"28d18e89fba53cc1ca5d46bd0b5d0964d0a7c75a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172677","number":172677,"mergeCommit":{"message":"[Security Solution] Default Risk score slide bar values are overlaid on Rule Creation page (#161456) (#172677)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/kibana/issues/161456\r\n\r\nThese changes do workaround to display EuiRange component which is\r\nbroken due to memoization (see more details in\r\nhttps://github.com//issues/160561 and\r\nhttps://github.com/elastic/eui/issues/6846)\r\n\r\nThe fix is to forcibly remove/add EuiRange component on About step\r\nactivation.\r\n\r\nBefore the fix:\r\n\r\n<img width=\"435\" alt=\"Screenshot 2023-07-12 at 19 06 01\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f\">\r\n\r\nAfter the fix:\r\n\r\n<img width=\"426\" alt=\"Screenshot 2023-07-12 at 19 05 46\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7\">","sha":"28d18e89fba53cc1ca5d46bd0b5d0964d0a7c75a"}}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #161456
These changes do workaround to display EuiRange component which is broken due to memoization (see more details in #160561 and elastic/eui#6846)
The fix is to forcibly remove/add EuiRange component on About step activation.
Before the fix:
After the fix: