Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Adding missing rule management groups to the flaky test suite runner #172354

Merged
merged 2 commits into from
Dec 1, 2023
Merged

[Security Solution] Adding missing rule management groups to the flaky test suite runner #172354

merged 2 commits into from
Dec 1, 2023

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Dec 1, 2023 •
edited
Loading

Summary

When we created the specific executions in buildkite for Rule Management team, we forgot to add the new groups to the flaky test suite runner. So, currently, the affected team is not able to exercise their tests on the flaky test suite runner.

In this PR we are fixing that.

@MadameSheema MadameSheema changed the title adding missing rule management executions [Security Solution] Adding missing rule management groups to the flaky test suite runner Dec 1, 2023
@MadameSheema MadameSheema self-assigned this Dec 1, 2023
@MadameSheema MadameSheema added v8.12.0 release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team:Detection Rule Management Security Detection Rule Management Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Dec 1, 2023
@MadameSheema MadameSheema marked this pull request as ready for review December 1, 2023 13:56
@MadameSheema MadameSheema requested a review from a team as a code owner December 1, 2023 13:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

banderror
banderror approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@banderror banderror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate your help @MadameSheema 🙏

@MadameSheema MadameSheema enabled auto-merge (squash) December 1, 2023 14:33
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema

@MadameSheema MadameSheema merged commit 7b7f19f into main Dec 1, 2023
@MadameSheema MadameSheema deleted the adding-rule-management-2-flaky-test-runner branch December 1, 2023 15:27
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

@banderror banderror banderror approved these changes

Assignees

@MadameSheema MadameSheema

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MadameSheema @elasticmachine @kibana-ci @jbudz @banderror @kibanamachine