Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Unskipping x-pack/test/security_solution_cypress/cypress/e2e/explore/pagination/ working tests on serverless #169474

Merged

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Oct 20, 2023

Update

With the newest tests added we need need to increase as well the number of nodes to avoid timeouts in CI.

As currently we are extremely close to arrive to achieve the parity between ESS and serverless tests, we are increasing the parallelism number to match the one we currently have for specific explore executions in ESS.

Summary

https://github.com/elastic/security-team/issues/7696

In this PR we are making the following changes regarding the tests living in x-pack/test/security_solution_cypress/cypress/e2e/explore/pagination/ regarding their execution on the first quality gate for serverless:

  • Unskips pagination.cy.ts tests.

Note that the unskipped tests have been executed several times and are passing consistently :)

Also, the tests that were marked before with .skip remain skipped in both executions.

@MadameSheema MadameSheema changed the title unskips pagination test for explore team [Security Solution] Unskipping x-pack/test/security_solution_cypress/cypress/e2e/explore/pagination/ working tests on serverless Oct 23, 2023
@MadameSheema MadameSheema self-assigned this Oct 23, 2023
@MadameSheema MadameSheema added v8.11.0 v8.12.0 Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore release_note:skip Skip the PR/issue when compiling release notes labels Oct 23, 2023
@MadameSheema MadameSheema marked this pull request as ready for review October 23, 2023 07:55
@MadameSheema MadameSheema requested a review from a team as a code owner October 23, 2023 07:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema MadameSheema requested a review from a team as a code owner October 24, 2023 09:15
@MadameSheema MadameSheema enabled auto-merge (squash) October 24, 2023 10:24
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema

@MadameSheema MadameSheema merged commit 6db8f5f into elastic:main Oct 24, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.11 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.11:
- [Security Solution] Adds more cypress tests on serverless for investigations team (#169379)

Manual backport

To create the backport manually run:

node scripts/backport --pr 169474

Questions ?

Please refer to the Backport tool documentation

@MadameSheema
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Oct 24, 2023
…/cypress/e2e/explore/pagination/` working tests on serverless (elastic#169474)

(cherry picked from commit 6db8f5f)

# Conflicts:
#	.buildkite/pipelines/on_merge.yml
#	.buildkite/pipelines/pull_request/base.yml
MadameSheema added a commit that referenced this pull request Oct 24, 2023
…cypress/cypress/e2e/explore/pagination/` working tests on serverless (#169474) (#169644)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Security Solution] Unskipping
`x-pack/test/security_solution_cypress/cypress/e2e/explore/pagination/`
working tests on serverless
(#169474)](#169474)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gloria
Hornero","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-24T10:48:55Z","message":"[Security
Solution] Unskipping
`x-pack/test/security_solution_cypress/cypress/e2e/explore/pagination/`
working tests on serverless
(#169474)","sha":"6db8f5fe6901bff9c80c461aeb077987ca8c9492","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.11.0","v8.12.0"],"number":169474,"url":"https://github.com/elastic/kibana/pull/169474","mergeCommit":{"message":"[Security
Solution] Unskipping
`x-pack/test/security_solution_cypress/cypress/e2e/explore/pagination/`
working tests on serverless
(#169474)","sha":"6db8f5fe6901bff9c80c461aeb077987ca8c9492"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169474","number":169474,"mergeCommit":{"message":"[Security
Solution] Unskipping
`x-pack/test/security_solution_cypress/cypress/e2e/explore/pagination/`
working tests on serverless
(#169474)","sha":"6db8f5fe6901bff9c80c461aeb077987ca8c9492"}}]}]
BACKPORT-->
@MadameSheema MadameSheema deleted the maximixing-coverage/pagination branch June 28, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.11.0 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants