Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Adds more cypress tests on serverless for investigations team #169379

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Oct 19, 2023

Update

With the newest tests added + newest changes in main looks like we need to increase as well the number of nodes to avoid timeouts in CI.

As currently we are extremely close to arrive to achieve the parity between ESS and serverless tests, we are increasing the parallelism number to match the one we currently have for specific investigations executions in ESS.

Summary

In this PR we are making the following changes regarding the tests living in x-pack/test/security_solution_cypress/cypress/e2e/investigations regarding their execution on the first quality gate for serverless:

  • Unskips alerts_charts.cy.ts
  • Unskips bulk_add_to_timeline.cy.ts
  • Unskips several tests inside timelines/creation.cy.ts
  • Unskips several tests inside timelines/pagination.cy.ts
  • Adds a reference to ticket with the reason why the tests are skipped in timelines/unsaved_timeline.cy.ts

Note that the unskipped tests have been executed several times and are passing consistently :)

Also, the tests that were marked before with .skip remain skipped in both executions.

@MadameSheema MadameSheema changed the title unskips alerts_charts spec in serverless [Security Solution] Adds more cypress tests on serverless for investigations team Oct 20, 2023
@MadameSheema MadameSheema self-assigned this Oct 23, 2023
@MadameSheema MadameSheema added v8.11.0 v8.12.0 Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team labels Oct 23, 2023
@MadameSheema MadameSheema marked this pull request as ready for review October 23, 2023 07:20
@MadameSheema MadameSheema requested a review from a team as a code owner October 23, 2023 07:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema MadameSheema added the release_note:skip Skip the PR/issue when compiling release notes label Oct 23, 2023
@MadameSheema MadameSheema requested a review from a team as a code owner October 23, 2023 08:32
@MadameSheema MadameSheema enabled auto-merge (squash) October 23, 2023 15:08
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema

@MadameSheema MadameSheema merged commit 0eb5925 into elastic:main Oct 23, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.11 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 169379

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 169379 locally

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 15, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 169379 locally

4 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 169379 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 169379 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 169379 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 169379 locally

@jbudz jbudz added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Apr 1, 2024
@MadameSheema MadameSheema deleted the maximizing-coverage/remaining-investigations branch June 28, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.11.0 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants