Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] rebrand ent-search breadcrumbs to Search #161586

Merged
merged 2 commits into from
Jul 11, 2023
Merged

[Enterprise Search] rebrand ent-search breadcrumbs to Search #161586

merged 2 commits into from
Jul 11, 2023

Conversation

TattdCodeMonkey
Copy link
Contributor

Summary

Updated the enterprise-search base breadcrumbs to Search except for App Search & Workplace Search remain with Enterprise Search.
Additionally fixed a small bug where the Vector Search breadcrumbs was Search > Vector Search > Vector Search

Screenshots

image image image

@TattdCodeMonkey TattdCodeMonkey added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.10.0 labels Jul 10, 2023
@TattdCodeMonkey TattdCodeMonkey requested a review from a team July 10, 2023 18:01
@TattdCodeMonkey TattdCodeMonkey force-pushed the rnorris/rebrand-ent-search-breadcrumbs branch from 430f321 to 0a2e4ba Compare July 10, 2023 18:34
saarikabhasi
saarikabhasi approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@saarikabhasi saarikabhasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TattdCodeMonkey TattdCodeMonkey force-pushed the rnorris/rebrand-ent-search-breadcrumbs branch from 0a2e4ba to 50c5b91 Compare July 11, 2023 21:02
@TattdCodeMonkey TattdCodeMonkey enabled auto-merge (squash) July 11, 2023 21:13
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.5MB 2.5MB +154.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 409 413 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 488 492 +4
total +6

History

  • 💚 Build #141369 succeeded 0a2e4ba93e8ec51fdb692c30a2ade35e5bf31b6e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TattdCodeMonkey TattdCodeMonkey merged commit a16f948 into elastic:main Jul 11, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphilipse sphilipse sphilipse left review comments

@saarikabhasi saarikabhasi saarikabhasi approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TattdCodeMonkey @kibana-ci @saarikabhasi @sphilipse @kibanamachine