Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Store last conversation in localstorage #6993 #161373

Merged
merged 8 commits into from
Jul 12, 2023
Merged

[Security Solution] Store last conversation in localstorage #6993 #161373

merged 8 commits into from
Jul 12, 2023

Conversation

lgestc
Copy link
Contributor

@lgestc lgestc commented Jul 6, 2023 •
edited
Loading

Summary

Fixes #6993

  • Tests?

@lgestc lgestc requested a review from spong July 6, 2023 15:45
@lgestc lgestc requested a review from spong July 7, 2023 13:32
@lgestc lgestc changed the title Store last conversation in in localstorage #6993 [Security Solution] Store last conversation in in localstorage #6993 Jul 7, 2023
@lgestc lgestc changed the title [Security Solution] Store last conversation in in localstorage #6993 [Security Solution] Store last conversation in localstorage #6993 Jul 7, 2023
@lgestc lgestc force-pushed the bugfix-6993 branch 2 times, most recently from 17b4d56 to 67da505 Compare July 7, 2023 14:10
@lgestc lgestc marked this pull request as ready for review July 7, 2023 15:09
@lgestc lgestc requested a review from a team as a code owner July 7, 2023 15:09
@lgestc lgestc added release_note:skip Skip the PR/issue when compiling release notes Feature:Security Assistant Security Assistant labels Jul 7, 2023
@lgestc lgestc requested a review from andrew-goldstein July 7, 2023 15:14
@lgestc lgestc requested a review from stephmilovic July 10, 2023 15:20
spong
spong reviewed Jul 11, 2023
View reviewed changes
x-pack/packages/kbn-elastic-assistant/impl/assistant/index.test.tsx
expect(persistToLocalStorage).toHaveBeenLastCalledWith('electric sheep');
});

it('should not persist the conversation id to local storage when excludeFromLastConversationStorage flag is indicated', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

spong
spong approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pair reviewed with @andrew-goldstein -- LGTU! Thank you @lgestc and @stephmilovic for the fix here 🙂

@stephmilovic stephmilovic enabled auto-merge (squash) July 11, 2023 23:57
@stephmilovic stephmilovic merged commit ca3146f into main Jul 12, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/elastic-assistant 64 65 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.1MB 11.1MB +1.8KB
Unknown metric groups

API count

id before after diff
@kbn/elastic-assistant 83 84 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 409 413 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 488 492 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic stephmilovic deleted the bugfix-6993 branch July 12, 2023 01:02
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Jul 12, 2023
@spong spong added v8.9.0 and removed backport:skip This commit does not require backporting labels Jul 12, 2023
@spong spong mentioned this pull request Jul 12, 2023
Merged
@spong
Copy link
Member

spong commented Jul 12, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

spong pushed a commit to spong/kibana that referenced this pull request Jul 12, 2023
@lgestc
[Security Solution] Store last conversation in localstorage elastic#6993
5c54496 
 (elastic#161373)

(cherry picked from commit ca3146f)
spong added a commit that referenced this pull request Jul 12, 2023
@spong @lgestc
[8.9] [Security Solution] Store last conversation in localstorage #6993…
f3015c7 
… (#161373) (#161743)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[Security Solution] Store last conversation in localstorage #6993
(#161373)](#161373)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Luke","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-12T01:02:11Z","message":"[Security
Solution] Store last conversation in localstorage #6993
(#161373)","sha":"ca3146f0ca5dc1d003214878bbf60d0aa1f00a1d","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.9.0","Feature:Elastic
Assistant","v8.10.0"],"number":161373,"url":"https://github.com/elastic/kibana/pull/161373","mergeCommit":{"message":"[Security
Solution] Store last conversation in localstorage #6993
(#161373)","sha":"ca3146f0ca5dc1d003214878bbf60d0aa1f00a1d"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161373","number":161373,"mergeCommit":{"message":"[Security
Solution] Store last conversation in localstorage #6993
(#161373)","sha":"ca3146f0ca5dc1d003214878bbf60d0aa1f00a1d"}}]}]
BACKPORT-->

Co-authored-by: Luke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephmilovic stephmilovic stephmilovic left review comments

@spong spong spong approved these changes

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

Assignees
No one assigned
Labels
Feature:Security Assistant Security Assistant release_note:skip Skip the PR/issue when compiling release notes v8.9.0 v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lgestc @kibana-ci @spong @andrew-goldstein @stephmilovic @kibanamachine