From 8ed866131b554d0f36f77f8f0a0cb5bee5961613 Mon Sep 17 00:00:00 2001 From: Bree Hall Date: Wed, 28 Jun 2023 16:19:08 -0400 Subject: [PATCH 01/28] Upgrade EUI to version 82.2.1 --- package.json | 2 +- src/dev/license_checker/config.ts | 2 +- yarn.lock | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index 151c9a4e74778..80ad06c5b2de9 100644 --- a/package.json +++ b/package.json @@ -98,7 +98,7 @@ "@elastic/datemath": "5.0.3", "@elastic/elasticsearch": "npm:@elastic/elasticsearch-canary@8.8.0-canary.2", "@elastic/ems-client": "8.4.0", - "@elastic/eui": "82.1.0", + "@elastic/eui": "82.2.1", "@elastic/filesaver": "1.1.2", "@elastic/node-crypto": "1.2.1", "@elastic/numeral": "^2.5.1", diff --git a/src/dev/license_checker/config.ts b/src/dev/license_checker/config.ts index 2f37cf29a79e0..0e3942e89f0a0 100644 --- a/src/dev/license_checker/config.ts +++ b/src/dev/license_checker/config.ts @@ -85,7 +85,7 @@ export const LICENSE_OVERRIDES = { 'jsts@1.6.2': ['Eclipse Distribution License - v 1.0'], // cf. https://github.com/bjornharrtell/jsts '@mapbox/jsonlint-lines-primitives@2.0.2': ['MIT'], // license in readme https://github.com/tmcw/jsonlint '@elastic/ems-client@8.4.0': ['Elastic License 2.0'], - '@elastic/eui@82.1.0': ['SSPL-1.0 OR Elastic License 2.0'], + '@elastic/eui@82.2.1': ['SSPL-1.0 OR Elastic License 2.0'], 'language-subtag-registry@0.3.21': ['CC-BY-4.0'], // retired ODC‑By license https://github.com/mattcg/language-subtag-registry 'buffers@0.1.1': ['MIT'], // license in importing module https://www.npmjs.com/package/binary }; diff --git a/yarn.lock b/yarn.lock index 83fad1204066f..6694dea59284d 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1552,10 +1552,10 @@ resolved "https://registry.yarnpkg.com/@elastic/eslint-plugin-eui/-/eslint-plugin-eui-0.0.2.tgz#56b9ef03984a05cc213772ae3713ea8ef47b0314" integrity sha512-IoxURM5zraoQ7C8f+mJb9HYSENiZGgRVcG4tLQxE61yHNNRDXtGDWTZh8N1KIHcsqN1CEPETjuzBXkJYF/fDiQ== -"@elastic/eui@82.1.0": - version "82.1.0" - resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-82.1.0.tgz#39816294a573c68b16eb729d80adebdd86614420" - integrity sha512-Y5zuPm4/n3dKKc0yxJxoq8m4UfjumKPixW5CCtKwFgjaZFw4RICDuNCkS11oSMQD7aYX2a1ie1EvD4OA4pa7ug== +"@elastic/eui@82.2.1": + version "82.2.1" + resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-82.2.1.tgz#60a03ba9c80ccedceb24badc66fecf11b1a334e3" + integrity sha512-wyJwY/tJuIawNgYuwVSZ163A4iFSMYavP8v/FcvgU52/o25rreIBpX0VXFhwgiTkoX49Z1Qfv2nUk6KYVk6LYA== dependencies: "@types/chroma-js" "^2.0.0" "@types/lodash" "^4.14.194" From dcc6762f4a0cf18c88d03747c5ed042a903e41f1 Mon Sep 17 00:00:00 2001 From: Bree Hall Date: Thu, 29 Jun 2023 16:25:41 -0400 Subject: [PATCH 02/28] Update EUI to version 83.0.0 --- package.json | 2 +- src/dev/license_checker/config.ts | 2 +- yarn.lock | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index c39758627fa26..40cba2edd9567 100644 --- a/package.json +++ b/package.json @@ -98,7 +98,7 @@ "@elastic/datemath": "5.0.3", "@elastic/elasticsearch": "npm:@elastic/elasticsearch-canary@8.8.0-canary.2", "@elastic/ems-client": "8.4.0", - "@elastic/eui": "82.2.1", + "@elastic/eui": "83.0.0", "@elastic/filesaver": "1.1.2", "@elastic/node-crypto": "1.2.1", "@elastic/numeral": "^2.5.1", diff --git a/src/dev/license_checker/config.ts b/src/dev/license_checker/config.ts index 0e3942e89f0a0..0b8584e026023 100644 --- a/src/dev/license_checker/config.ts +++ b/src/dev/license_checker/config.ts @@ -85,7 +85,7 @@ export const LICENSE_OVERRIDES = { 'jsts@1.6.2': ['Eclipse Distribution License - v 1.0'], // cf. https://github.com/bjornharrtell/jsts '@mapbox/jsonlint-lines-primitives@2.0.2': ['MIT'], // license in readme https://github.com/tmcw/jsonlint '@elastic/ems-client@8.4.0': ['Elastic License 2.0'], - '@elastic/eui@82.2.1': ['SSPL-1.0 OR Elastic License 2.0'], + '@elastic/eui@83.0.0': ['SSPL-1.0 OR Elastic License 2.0'], 'language-subtag-registry@0.3.21': ['CC-BY-4.0'], // retired ODC‑By license https://github.com/mattcg/language-subtag-registry 'buffers@0.1.1': ['MIT'], // license in importing module https://www.npmjs.com/package/binary }; diff --git a/yarn.lock b/yarn.lock index d007beb443ba0..7bf70c487f02e 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1552,10 +1552,10 @@ resolved "https://registry.yarnpkg.com/@elastic/eslint-plugin-eui/-/eslint-plugin-eui-0.0.2.tgz#56b9ef03984a05cc213772ae3713ea8ef47b0314" integrity sha512-IoxURM5zraoQ7C8f+mJb9HYSENiZGgRVcG4tLQxE61yHNNRDXtGDWTZh8N1KIHcsqN1CEPETjuzBXkJYF/fDiQ== -"@elastic/eui@82.2.1": - version "82.2.1" - resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-82.2.1.tgz#60a03ba9c80ccedceb24badc66fecf11b1a334e3" - integrity sha512-wyJwY/tJuIawNgYuwVSZ163A4iFSMYavP8v/FcvgU52/o25rreIBpX0VXFhwgiTkoX49Z1Qfv2nUk6KYVk6LYA== +"@elastic/eui@83.0.0": + version "83.0.0" + resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-83.0.0.tgz#32d6a4516ff4bbc058cf604cf323536ce57748e7" + integrity sha512-xoGa/+WmqNV4+GwM7k9u610nAzL4MiWLns55qZdkftuN0zOwFjlnQS2bd+NJlNNXVB9PfeOIKfpvdB4iMIRsFA== dependencies: "@types/chroma-js" "^2.0.0" "@types/lodash" "^4.14.194" From 905a22dec5878b3fbe195cd5e5c07e541d47d384 Mon Sep 17 00:00:00 2001 From: Bree Hall Date: Wed, 28 Jun 2023 16:19:08 -0400 Subject: [PATCH 03/28] Upgrade EUI to version 82.2.1 --- package.json | 2 +- src/dev/license_checker/config.ts | 2 +- yarn.lock | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index 2fce048b21557..d833a7d21d8f2 100644 --- a/package.json +++ b/package.json @@ -98,7 +98,7 @@ "@elastic/datemath": "5.0.3", "@elastic/elasticsearch": "npm:@elastic/elasticsearch-canary@8.8.0-canary.2", "@elastic/ems-client": "8.4.0", - "@elastic/eui": "82.1.0", + "@elastic/eui": "82.2.1", "@elastic/filesaver": "1.1.2", "@elastic/node-crypto": "1.2.1", "@elastic/numeral": "^2.5.1", diff --git a/src/dev/license_checker/config.ts b/src/dev/license_checker/config.ts index 2f37cf29a79e0..0e3942e89f0a0 100644 --- a/src/dev/license_checker/config.ts +++ b/src/dev/license_checker/config.ts @@ -85,7 +85,7 @@ export const LICENSE_OVERRIDES = { 'jsts@1.6.2': ['Eclipse Distribution License - v 1.0'], // cf. https://github.com/bjornharrtell/jsts '@mapbox/jsonlint-lines-primitives@2.0.2': ['MIT'], // license in readme https://github.com/tmcw/jsonlint '@elastic/ems-client@8.4.0': ['Elastic License 2.0'], - '@elastic/eui@82.1.0': ['SSPL-1.0 OR Elastic License 2.0'], + '@elastic/eui@82.2.1': ['SSPL-1.0 OR Elastic License 2.0'], 'language-subtag-registry@0.3.21': ['CC-BY-4.0'], // retired ODC‑By license https://github.com/mattcg/language-subtag-registry 'buffers@0.1.1': ['MIT'], // license in importing module https://www.npmjs.com/package/binary }; diff --git a/yarn.lock b/yarn.lock index b34388e82f10a..8519726abd64b 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1552,10 +1552,10 @@ resolved "https://registry.yarnpkg.com/@elastic/eslint-plugin-eui/-/eslint-plugin-eui-0.0.2.tgz#56b9ef03984a05cc213772ae3713ea8ef47b0314" integrity sha512-IoxURM5zraoQ7C8f+mJb9HYSENiZGgRVcG4tLQxE61yHNNRDXtGDWTZh8N1KIHcsqN1CEPETjuzBXkJYF/fDiQ== -"@elastic/eui@82.1.0": - version "82.1.0" - resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-82.1.0.tgz#39816294a573c68b16eb729d80adebdd86614420" - integrity sha512-Y5zuPm4/n3dKKc0yxJxoq8m4UfjumKPixW5CCtKwFgjaZFw4RICDuNCkS11oSMQD7aYX2a1ie1EvD4OA4pa7ug== +"@elastic/eui@82.2.1": + version "82.2.1" + resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-82.2.1.tgz#60a03ba9c80ccedceb24badc66fecf11b1a334e3" + integrity sha512-wyJwY/tJuIawNgYuwVSZ163A4iFSMYavP8v/FcvgU52/o25rreIBpX0VXFhwgiTkoX49Z1Qfv2nUk6KYVk6LYA== dependencies: "@types/chroma-js" "^2.0.0" "@types/lodash" "^4.14.194" From 0fdb89c06a1fde823cd50572c085220efbd51323 Mon Sep 17 00:00:00 2001 From: Bree Hall Date: Thu, 29 Jun 2023 16:25:41 -0400 Subject: [PATCH 04/28] Update EUI to version 83.0.0 --- package.json | 2 +- src/dev/license_checker/config.ts | 2 +- yarn.lock | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index d833a7d21d8f2..2b9247d4d8149 100644 --- a/package.json +++ b/package.json @@ -98,7 +98,7 @@ "@elastic/datemath": "5.0.3", "@elastic/elasticsearch": "npm:@elastic/elasticsearch-canary@8.8.0-canary.2", "@elastic/ems-client": "8.4.0", - "@elastic/eui": "82.2.1", + "@elastic/eui": "83.0.0", "@elastic/filesaver": "1.1.2", "@elastic/node-crypto": "1.2.1", "@elastic/numeral": "^2.5.1", diff --git a/src/dev/license_checker/config.ts b/src/dev/license_checker/config.ts index 0e3942e89f0a0..0b8584e026023 100644 --- a/src/dev/license_checker/config.ts +++ b/src/dev/license_checker/config.ts @@ -85,7 +85,7 @@ export const LICENSE_OVERRIDES = { 'jsts@1.6.2': ['Eclipse Distribution License - v 1.0'], // cf. https://github.com/bjornharrtell/jsts '@mapbox/jsonlint-lines-primitives@2.0.2': ['MIT'], // license in readme https://github.com/tmcw/jsonlint '@elastic/ems-client@8.4.0': ['Elastic License 2.0'], - '@elastic/eui@82.2.1': ['SSPL-1.0 OR Elastic License 2.0'], + '@elastic/eui@83.0.0': ['SSPL-1.0 OR Elastic License 2.0'], 'language-subtag-registry@0.3.21': ['CC-BY-4.0'], // retired ODC‑By license https://github.com/mattcg/language-subtag-registry 'buffers@0.1.1': ['MIT'], // license in importing module https://www.npmjs.com/package/binary }; diff --git a/yarn.lock b/yarn.lock index 8519726abd64b..240bd74940993 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1552,10 +1552,10 @@ resolved "https://registry.yarnpkg.com/@elastic/eslint-plugin-eui/-/eslint-plugin-eui-0.0.2.tgz#56b9ef03984a05cc213772ae3713ea8ef47b0314" integrity sha512-IoxURM5zraoQ7C8f+mJb9HYSENiZGgRVcG4tLQxE61yHNNRDXtGDWTZh8N1KIHcsqN1CEPETjuzBXkJYF/fDiQ== -"@elastic/eui@82.2.1": - version "82.2.1" - resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-82.2.1.tgz#60a03ba9c80ccedceb24badc66fecf11b1a334e3" - integrity sha512-wyJwY/tJuIawNgYuwVSZ163A4iFSMYavP8v/FcvgU52/o25rreIBpX0VXFhwgiTkoX49Z1Qfv2nUk6KYVk6LYA== +"@elastic/eui@83.0.0": + version "83.0.0" + resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-83.0.0.tgz#32d6a4516ff4bbc058cf604cf323536ce57748e7" + integrity sha512-xoGa/+WmqNV4+GwM7k9u610nAzL4MiWLns55qZdkftuN0zOwFjlnQS2bd+NJlNNXVB9PfeOIKfpvdB4iMIRsFA== dependencies: "@types/chroma-js" "^2.0.0" "@types/lodash" "^4.14.194" From f5c05aeeeb09ea08b5b70086ee082bf27996094a Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Thu, 29 Jun 2023 12:19:44 -0700 Subject: [PATCH 05/28] [EuiButtonIcon] Remove direct class usage in favor of `isLoading` prop - comment is likely no longer accurate (4 years old), and `EuiButtonIcon` supports a loading spinner just fine --- .../__snapshots__/layer_control.test.tsx.snap | 16 ++++++++-------- .../layer_control/layer_control.tsx | 17 +---------------- 2 files changed, 9 insertions(+), 24 deletions(-) diff --git a/x-pack/plugins/maps/public/connected_components/right_side_controls/layer_control/__snapshots__/layer_control.test.tsx.snap b/x-pack/plugins/maps/public/connected_components/right_side_controls/layer_control/__snapshots__/layer_control.test.tsx.snap index 8c6e442d34dbf..71a4053d105cc 100644 --- a/x-pack/plugins/maps/public/connected_components/right_side_controls/layer_control/__snapshots__/layer_control.test.tsx.snap +++ b/x-pack/plugins/maps/public/connected_components/right_side_controls/layer_control/__snapshots__/layer_control.test.tsx.snap @@ -127,6 +127,7 @@ exports[`LayerControl isLayerTOCOpen Should render expand button 1`] = ` color="text" data-test-subj="mapExpandLayerControlButton" iconType="menuLeft" + isLoading={false} onClick={[Function]} /> @@ -145,6 +146,7 @@ exports[`LayerControl isLayerTOCOpen Should render expand button with error icon color="text" data-test-subj="mapExpandLayerControlButton" iconType="warning" + isLoading={false} onClick={[Function]} /> @@ -157,17 +159,15 @@ exports[`LayerControl isLayerTOCOpen Should render expand button with loading ic display="inlineBlock" position="left" > - + /> `; diff --git a/x-pack/plugins/maps/public/connected_components/right_side_controls/layer_control/layer_control.tsx b/x-pack/plugins/maps/public/connected_components/right_side_controls/layer_control/layer_control.tsx index d79f0360b9071..7a4e04066b37c 100644 --- a/x-pack/plugins/maps/public/connected_components/right_side_controls/layer_control/layer_control.tsx +++ b/x-pack/plugins/maps/public/connected_components/right_side_controls/layer_control/layer_control.tsx @@ -15,7 +15,6 @@ import { EuiSpacer, EuiButtonIcon, EuiToolTip, - EuiLoadingSpinner, } from '@elastic/eui'; import { FormattedMessage } from '@kbn/i18n-react'; import { i18n } from '@kbn/i18n'; @@ -49,25 +48,11 @@ function renderExpandButton({ defaultMessage: 'Expand layers panel', }); - if (isLoading) { - // Can not use EuiButtonIcon with spinner because spinner is a class and not an icon - return ( - - ); - } - return ( Date: Thu, 29 Jun 2023 12:28:55 -0700 Subject: [PATCH 06/28] [EuiButtonIcon] Fix test assertions - Remove references to removed modifier classes - Prefer checks for `disabled` prop over className checks --- .../header_actions/add_note_icon_item.test.tsx | 4 +--- .../public/components/session_view/index.test.tsx | 4 +--- .../step_detail/waterfall/waterfall_filter.test.tsx | 12 ++++-------- .../page_objects/detections/index.ts | 2 +- 4 files changed, 7 insertions(+), 15 deletions(-) diff --git a/x-pack/plugins/security_solution/public/common/components/header_actions/add_note_icon_item.test.tsx b/x-pack/plugins/security_solution/public/common/components/header_actions/add_note_icon_item.test.tsx index 0883d235a92e5..4c3fc4a88e4c8 100644 --- a/x-pack/plugins/security_solution/public/common/components/header_actions/add_note_icon_item.test.tsx +++ b/x-pack/plugins/security_solution/public/common/components/header_actions/add_note_icon_item.test.tsx @@ -58,9 +58,7 @@ describe('AddEventNoteAction', () => { ); - expect(screen.getByTestId('timeline-notes-button-small')).not.toHaveClass( - 'euiButtonIcon-isDisabled' - ); + expect(screen.getByTestId('timeline-notes-button-small')).not.toBeDisabled(); }); }); }); diff --git a/x-pack/plugins/session_view/public/components/session_view/index.test.tsx b/x-pack/plugins/session_view/public/components/session_view/index.test.tsx index a7ea2dfad57c3..ffaea2547c012 100644 --- a/x-pack/plugins/session_view/public/components/session_view/index.test.tsx +++ b/x-pack/plugins/session_view/public/components/session_view/index.test.tsx @@ -235,9 +235,7 @@ describe('SessionView component', () => { render(); await waitFor(() => { - expect(renderResult.queryByTestId('sessionView:TTYPlayerToggle')?.classList[2]).toContain( - 'disabled' - ); + expect(renderResult.queryByTestId('sessionView:TTYPlayerToggle')).toBeDisabled(); }); }); }); diff --git a/x-pack/plugins/uptime/public/legacy_uptime/components/monitor/synthetics/step_detail/waterfall/waterfall_filter.test.tsx b/x-pack/plugins/uptime/public/legacy_uptime/components/monitor/synthetics/step_detail/waterfall/waterfall_filter.test.tsx index fd1737879541b..d49b034b9ba7e 100644 --- a/x-pack/plugins/uptime/public/legacy_uptime/components/monitor/synthetics/step_detail/waterfall/waterfall_filter.test.tsx +++ b/x-pack/plugins/uptime/public/legacy_uptime/components/monitor/synthetics/step_detail/waterfall/waterfall_filter.test.tsx @@ -61,19 +61,15 @@ describe('waterfall filter', () => { fireEvent.click(getByTitle('XHR')); - expect(getByLabelText(FILTER_POPOVER_OPEN_LABEL).classList[2]).toContain( - 'euiButtonIcon-empty-primary-hoverStyles' + expect(getByLabelText(FILTER_POPOVER_OPEN_LABEL).getAttribute('class')).toContain( + 'euiButtonIcon-xs-empty-primary' ); // toggle it back to inactive fireEvent.click(getByTitle('XHR')); - expect(getByLabelText(FILTER_POPOVER_OPEN_LABEL).classList[1]).toContain( - 'euiButtonIcon--xSmall' - ); - - expect(getByLabelText(FILTER_POPOVER_OPEN_LABEL).classList[2]).toContain( - 'euiButtonIcon-empty-text-hoverStyles' + expect(getByLabelText(FILTER_POPOVER_OPEN_LABEL).getAttribute('class')).toContain( + 'euiButtonIcon-xs-empty-text' ); }); diff --git a/x-pack/test/security_solution_ftr/page_objects/detections/index.ts b/x-pack/test/security_solution_ftr/page_objects/detections/index.ts index 83622afefcd0a..9d5abd2631be1 100644 --- a/x-pack/test/security_solution_ftr/page_objects/detections/index.ts +++ b/x-pack/test/security_solution_ftr/page_objects/detections/index.ts @@ -66,7 +66,7 @@ export class DetectionsPageObject extends FtrService { } async closeImportQueryModal(): Promise { - await this.find.clickByCssSelector('.euiButtonIcon.euiButtonIcon--text.euiModal__closeIcon'); + await this.find.clickByCssSelector('.euiButtonIcon.euiModal__closeIcon'); } async selectMachineLearningJob(): Promise { From 28743753b19aa43f8ffd06c83fe1b02684832dd6 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Thu, 29 Jun 2023 13:57:11 -0700 Subject: [PATCH 07/28] [EuiButtonEmpty] Remove padding CSS unsets in favor of using `flush` prop --- .../resource_findings_container.tsx | 10 +--------- .../resource_vulnerabilities.tsx | 10 +--------- .../utility_bar/utility_bar_action.tsx | 6 ++---- .../components/timeline/footer/index.tsx | 20 +++---------------- .../certificates/fingerprint_col.tsx | 10 +++------- .../certificates/fingerprint_col.tsx | 8 +------- 6 files changed, 11 insertions(+), 53 deletions(-) diff --git a/x-pack/plugins/cloud_security_posture/public/pages/configurations/latest_findings_by_resource/resource_findings/resource_findings_container.tsx b/x-pack/plugins/cloud_security_posture/public/pages/configurations/latest_findings_by_resource/resource_findings/resource_findings_container.tsx index 1ea6a460a41fc..f9114a537c3c8 100644 --- a/x-pack/plugins/cloud_security_posture/public/pages/configurations/latest_findings_by_resource/resource_findings/resource_findings_container.tsx +++ b/x-pack/plugins/cloud_security_posture/public/pages/configurations/latest_findings_by_resource/resource_findings/resource_findings_container.tsx @@ -10,7 +10,6 @@ import { Link, useParams } from 'react-router-dom'; import { FormattedMessage } from '@kbn/i18n-react'; import { generatePath } from 'react-router-dom'; import { i18n } from '@kbn/i18n'; -import { css } from '@emotion/react'; import { CspInlineDescriptionList } from '../../../../components/csp_inline_description_list'; import type { Evaluation } from '../../../../../common/types'; import { CspFinding } from '../../../../../common/schemas/csp_finding'; @@ -45,14 +44,7 @@ const getDefaultQuery = ({ const BackToResourcesButton = () => ( - + placeholder={SEARCH_BAR_PLACEHOLDER} /> - + css` - &.euiButtonEmpty.euiButtonEmpty--xSmall { + &.euiButtonEmpty { height: ${theme.eui.euiSize}; - .euiButtonEmpty__content { - padding: 0; - } } `} `; @@ -110,6 +107,7 @@ export const UtilityBarAction = React.memo( className="eui-alignTop" isLoading iconSide="right" + flush="both" > {children} diff --git a/x-pack/plugins/security_solution/public/timelines/components/timeline/footer/index.tsx b/x-pack/plugins/security_solution/public/timelines/components/timeline/footer/index.tsx index 7f6f3be990efd..b37139f6b8406 100644 --- a/x-pack/plugins/security_solution/public/timelines/components/timeline/footer/index.tsx +++ b/x-pack/plugins/security_solution/public/timelines/components/timeline/footer/index.tsx @@ -5,7 +5,6 @@ * 2.0. */ -import type { EuiPopoverProps } from '@elastic/eui'; import { EuiBadge, EuiButtonEmpty, @@ -20,7 +19,6 @@ import { EuiPagination, } from '@elastic/eui'; import { FormattedMessage } from '@kbn/i18n-react'; -import type { FC } from 'react'; import React, { useCallback, useEffect, useState, useMemo } from 'react'; import styled from 'styled-components'; import { useDispatch } from 'react-redux'; @@ -91,19 +89,6 @@ const LoadingPanelContainer = styled.div` LoadingPanelContainer.displayName = 'LoadingPanelContainer'; -const PopoverRowItems = styled(EuiPopover as unknown as FC)< - EuiPopoverProps & { - className?: string; - id?: string; - } ->` - .euiButtonEmpty__content { - padding: 0px 0px; - } -`; - -PopoverRowItems.displayName = 'PopoverRowItems'; - export const ServerSideEventCount = styled.div` margin: 0 5px 0 5px; `; @@ -139,7 +124,7 @@ export const EventsCountComponent = ({ ); return (
- - + diff --git a/x-pack/plugins/synthetics/public/apps/synthetics/components/certificates/fingerprint_col.tsx b/x-pack/plugins/synthetics/public/apps/synthetics/components/certificates/fingerprint_col.tsx index 2b1fca1605856..138ae4d1073cc 100644 --- a/x-pack/plugins/synthetics/public/apps/synthetics/components/certificates/fingerprint_col.tsx +++ b/x-pack/plugins/synthetics/public/apps/synthetics/components/certificates/fingerprint_col.tsx @@ -11,12 +11,6 @@ import styled from 'styled-components'; import { Cert } from '../../../../../common/runtime_types'; import { COPY_FINGERPRINT } from './translations'; -const EmptyButton = styled(EuiButtonEmpty)` - .euiButtonEmpty__content { - padding-right: 0px; - } -`; - const StyledSpan = styled.span` margin-right: 8px; `; @@ -30,7 +24,9 @@ export const FingerprintCol: React.FC = ({ cert }) => { return ( - {text} + + {text}{' '} + {(copy) => ( diff --git a/x-pack/plugins/uptime/public/legacy_uptime/components/certificates/fingerprint_col.tsx b/x-pack/plugins/uptime/public/legacy_uptime/components/certificates/fingerprint_col.tsx index dac9f239eb104..8e6d3c5ad86f9 100644 --- a/x-pack/plugins/uptime/public/legacy_uptime/components/certificates/fingerprint_col.tsx +++ b/x-pack/plugins/uptime/public/legacy_uptime/components/certificates/fingerprint_col.tsx @@ -11,12 +11,6 @@ import styled from 'styled-components'; import { Cert } from '../../../../common/runtime_types'; import { COPY_FINGERPRINT } from './translations'; -const EmptyButton = styled(EuiButtonEmpty)` - .euiButtonEmpty__content { - padding-right: 0px; - } -`; - const StyledSpan = styled.span` margin-right: 8px; `; @@ -30,7 +24,7 @@ export const FingerprintCol: React.FC = ({ cert }) => { return ( - {text} + {text} {(copy) => ( From 7a180b40fd6ec77e86ed52dc4e88f3343a733e75 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Thu, 29 Jun 2023 13:59:08 -0700 Subject: [PATCH 08/28] [EuiButtonEmpty] Replace direct `.euiButtonEmpty` className reference - these classNames no longer have any CSS attached due to the Emotion conversion - AFAICT, the overrides are primarily around text size and weight, so set those intead - use components where possible and Emotion CSS instead of inline style --- .../api_keys_grid/api_keys_empty_prompt.tsx | 22 +++++++++++-------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/x-pack/plugins/security/public/management/api_keys/api_keys_grid/api_keys_empty_prompt.tsx b/x-pack/plugins/security/public/management/api_keys/api_keys_grid/api_keys_empty_prompt.tsx index c6d463137d417..c76b385cfccc5 100644 --- a/x-pack/plugins/security/public/management/api_keys/api_keys_grid/api_keys_empty_prompt.tsx +++ b/x-pack/plugins/security/public/management/api_keys/api_keys_grid/api_keys_empty_prompt.tsx @@ -5,7 +5,8 @@ * 2.0. */ -import { EuiAccordion, EuiErrorBoundary, EuiSpacer, EuiText } from '@elastic/eui'; +import { EuiAccordion, EuiErrorBoundary, EuiSpacer, EuiText, useEuiTheme } from '@elastic/eui'; +import { css } from '@emotion/css'; import type { FunctionComponent } from 'react'; import React from 'react'; @@ -25,6 +26,7 @@ export const ApiKeysEmptyPrompt: FunctionComponent = ({ readOnly, children, }) => { + const { euiTheme } = useEuiTheme(); const accordionId = useHtmlId('apiKeysEmptyPrompt', 'accordion'); if (error) { @@ -92,16 +94,18 @@ export const ApiKeysEmptyPrompt: FunctionComponent = ({ + + + } - buttonProps={{ - style: { display: 'flex', justifyContent: 'center' }, - }} arrowDisplay="right" paddingSize="m" > From c3088243b3590a3b06e8b1e4329c168cfede5c9c Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Thu, 29 Jun 2023 14:11:22 -0700 Subject: [PATCH 09/28] [EuiButtonEmpty][cases] Replace direct `.euiButtonEmpty` className usage - these classNames no longer have any CSS attached due to the Emotion conversion - AFAICT, the overrides are primarily around text size and weight, as well as an incidental hover, so set those instead --- .../configure_cases/connectors_dropdown.tsx | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/x-pack/plugins/cases/public/components/configure_cases/connectors_dropdown.tsx b/x-pack/plugins/cases/public/components/configure_cases/connectors_dropdown.tsx index 2ef2b61cedcb6..db4ea027a087f 100644 --- a/x-pack/plugins/cases/public/components/configure_cases/connectors_dropdown.tsx +++ b/x-pack/plugins/cases/public/components/configure_cases/connectors_dropdown.tsx @@ -31,6 +31,16 @@ const EuiIconExtended = styled(EuiIcon)` margin-bottom: 0 !important; `; +const AddNewConnectorOption = styled.span` + font-size: ${(props) => props.theme.eui.euiFontSizeXS}; + font-weight: ${(props) => props.theme.eui.euiFontWeightMedium}; + line-height: ${(props) => props.theme.eui.euiSizeL}; + + &:hover { + text-decoration: underline; + } +`; + const noConnectorOption = { value: 'none', inputDisplay: ( @@ -48,11 +58,7 @@ const noConnectorOption = { const addNewConnector = { value: 'add-connector', - inputDisplay: ( - - {i18n.ADD_NEW_CONNECTOR} - - ), + inputDisplay: {i18n.ADD_NEW_CONNECTOR}, 'data-test-subj': 'dropdown-connector-add-connector', }; From 6ac82e6b30d4ad56183be409626b4b999a8f370a Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Thu, 29 Jun 2023 14:14:39 -0700 Subject: [PATCH 10/28] [EuiButtonEmpty] Clean up custom padding declaration - remove `__content` selector - padding is now set on the parent button - use EUI theme var instead of static px width - clean up minimizePadding ternary - removing padding class on `EuiButtonIcon` which does not set any padding --- .../filter_item/actions/actions.tsx | 17 +++++++++++++---- .../filter_item/filter_item.styles.ts | 6 ++---- 2 files changed, 15 insertions(+), 8 deletions(-) diff --git a/src/plugins/unified_search/public/filters_builder/filter_item/actions/actions.tsx b/src/plugins/unified_search/public/filters_builder/filter_item/actions/actions.tsx index 45e77bfaac6cd..37b62b33cc618 100644 --- a/src/plugins/unified_search/public/filters_builder/filter_item/actions/actions.tsx +++ b/src/plugins/unified_search/public/filters_builder/filter_item/actions/actions.tsx @@ -7,7 +7,13 @@ */ import React, { FC } from 'react'; -import { EuiButtonEmpty, EuiButtonIcon, EuiFlexGroup, EuiFlexItem } from '@elastic/eui'; +import { + EuiButtonEmpty, + EuiButtonIcon, + EuiFlexGroup, + EuiFlexItem, + useEuiTheme, +} from '@elastic/eui'; import { Tooltip } from '../tooltip'; import { strings } from './action_strings'; import { FilterItemActionsProps } from './types'; @@ -25,6 +31,9 @@ export const FilterItemActions: FC { + const { euiTheme } = useEuiTheme(); + const actionButtonClassName = actionButtonCss(euiTheme); + return ( @@ -36,7 +45,7 @@ export const FilterItemActions: FC @@ -51,7 +60,7 @@ export const FilterItemActions: FC {strings.getAddOrFilterGroupButtonLabel()} @@ -68,7 +77,7 @@ export const FilterItemActions: FC {strings.getAddAndFilterGroupButtonLabel()} diff --git a/src/plugins/unified_search/public/filters_builder/filter_item/filter_item.styles.ts b/src/plugins/unified_search/public/filters_builder/filter_item/filter_item.styles.ts index ef9cddfd025f5..5ca888735f5ad 100644 --- a/src/plugins/unified_search/public/filters_builder/filter_item/filter_item.styles.ts +++ b/src/plugins/unified_search/public/filters_builder/filter_item/filter_item.styles.ts @@ -36,10 +36,8 @@ export const getGrabIconCss = (euiTheme: EuiThemeComputed) => css` margin: 0 ${euiTheme.size.xxs}; `; -export const actionButtonCss = css` - &.euiButtonEmpty .euiButtonEmpty__content { - padding: 0 4px; - } +export const actionButtonCss = (euiTheme: EuiThemeComputed) => css` + padding-inline: ${euiTheme.size.xs}; `; export const disabledDraggableCss = css` From 0eef8abcaf84a4234848923d36032c1371493f7c Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Thu, 29 Jun 2023 14:18:55 -0700 Subject: [PATCH 11/28] [EuiButtonEmpty] Update padding override selectors - EuiButtonEmpty now has its padding set on the top-most button, and not on `euiButtonEmpty__content` + use new logical `-inline` property while here, which sets both horizontal sides at once --- .../components/deduplication_panel/deduplication_panel.scss | 5 ++--- .../deduplication_panel/deduplication_panel.scss | 5 ++--- .../ml_inference/add_inference_pipeline_flyout.scss | 5 ++--- .../components/tree_view_container/breadcrumb/styles.ts | 5 ++--- .../lens/public/embeddable/embeddable_info_badges.tsx | 4 ++-- x-pack/plugins/security/public/management/table_utils.tsx | 4 ++-- .../common/components/header_actions/header_actions.tsx | 2 +- 7 files changed, 13 insertions(+), 17 deletions(-) diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/deduplication_panel/deduplication_panel.scss b/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/deduplication_panel/deduplication_panel.scss index 6190a0beb91bc..68b0d3e819aab 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/deduplication_panel/deduplication_panel.scss +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/deduplication_panel/deduplication_panel.scss @@ -6,9 +6,8 @@ } .showAllFieldsPopoverToggle { - .euiButtonEmpty__content { - padding-left: $euiSizeM; - padding-right: $euiSizeM; + .euiButtonEmpty { + padding-inline: $euiSizeM; } } } diff --git a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/crawler_domain_detail/deduplication_panel/deduplication_panel.scss b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/crawler_domain_detail/deduplication_panel/deduplication_panel.scss index 6190a0beb91bc..68b0d3e819aab 100644 --- a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/crawler_domain_detail/deduplication_panel/deduplication_panel.scss +++ b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/crawler_domain_detail/deduplication_panel/deduplication_panel.scss @@ -6,9 +6,8 @@ } .showAllFieldsPopoverToggle { - .euiButtonEmpty__content { - padding-left: $euiSizeM; - padding-right: $euiSizeM; + .euiButtonEmpty { + padding-inline: $euiSizeM; } } } diff --git a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/ml_inference/add_inference_pipeline_flyout.scss b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/ml_inference/add_inference_pipeline_flyout.scss index 70950078cb641..2f6f86d98618c 100644 --- a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/ml_inference/add_inference_pipeline_flyout.scss +++ b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/ml_inference/add_inference_pipeline_flyout.scss @@ -15,9 +15,8 @@ } .enterpriseSearchInferencePipelineFlyoutFooter { - .euiButtonEmpty__content { - padding-left: $euiSizeM; - padding-right: $euiSizeM; + .euiButtonEmpty { + padding-inline: $euiSizeM; } } } diff --git a/x-pack/plugins/kubernetes_security/public/components/tree_view_container/breadcrumb/styles.ts b/x-pack/plugins/kubernetes_security/public/components/tree_view_container/breadcrumb/styles.ts index 1e8b63668b1d5..82f98750879bb 100644 --- a/x-pack/plugins/kubernetes_security/public/components/tree_view_container/breadcrumb/styles.ts +++ b/x-pack/plugins/kubernetes_security/public/components/tree_view_container/breadcrumb/styles.ts @@ -27,9 +27,8 @@ export const useStyles = () => { maxWidth: '248px', fontSize: size.m, fontWeight: font.weight.regular, - '.euiButtonEmpty__content': { - paddingLeft: size.xs, - paddingRight: size.xs, + '.euiButtonEmpty': { + paddingInline: size.xs, }, }; diff --git a/x-pack/plugins/lens/public/embeddable/embeddable_info_badges.tsx b/x-pack/plugins/lens/public/embeddable/embeddable_info_badges.tsx index fcfb33053ee68..acace55c0f673 100644 --- a/x-pack/plugins/lens/public/embeddable/embeddable_info_badges.tsx +++ b/x-pack/plugins/lens/public/embeddable/embeddable_info_badges.tsx @@ -66,8 +66,8 @@ export const EmbeddableFeatureBadge = ({ messages }: { messages: UserMessage[] } color: transparent; font-size: ${xsFontSize}; height: ${euiTheme.size.l} !important; - .euiButtonEmpty__content { - padding: 0 ${euiTheme.size.xs}; + .euiButtonEmpty { + padding-inline: ${euiTheme.size.xs}; } .euiButtonEmpty__text { margin-inline-start: ${euiTheme.size.xs}; diff --git a/x-pack/plugins/security/public/management/table_utils.tsx b/x-pack/plugins/security/public/management/table_utils.tsx index 3f240daf3bd03..74dd51f1cad85 100644 --- a/x-pack/plugins/security/public/management/table_utils.tsx +++ b/x-pack/plugins/security/public/management/table_utils.tsx @@ -23,8 +23,8 @@ export const ActionsEuiTableFormatting = React.memo (
theme.eui.euiColorPrimary}; } - .euiPopover .euiButtonEmpty .euiButtonContent { + .euiPopover .euiButtonEmpty { padding: 0; .euiButtonEmpty__text { From ef0ae19dc4706d4c6892240337b9f416e1fb3f79 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Thu, 29 Jun 2023 14:20:53 -0700 Subject: [PATCH 12/28] [EuiButtonEmpty] Update text selectors `.euiButtonEmpty__text` no longer uses `margin-left` to set a distance between any icon(s) and text, instead `.euiButtonEmpty__content` now sets a flex `gap` property --- .../public/components/dimension_buttons/empty_button.tsx | 5 +---- .../lens/public/embeddable/embeddable_info_badges.tsx | 4 ++-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/plugins/visualization_ui_components/public/components/dimension_buttons/empty_button.tsx b/src/plugins/visualization_ui_components/public/components/dimension_buttons/empty_button.tsx index e66d512e80f73..5b0cf67789879 100644 --- a/src/plugins/visualization_ui_components/public/components/dimension_buttons/empty_button.tsx +++ b/src/plugins/visualization_ui_components/public/components/dimension_buttons/empty_button.tsx @@ -42,10 +42,7 @@ export const EmptyDimensionButton = ({ justify-content: flex-start; padding: 0 !important; color: ${euiThemeVars.euiTextSubduedColor}; - - .euiButtonEmpty__text { - margin-left: 0; - } + gap: 0; .euiIcon { margin-left: ${euiThemeVars.euiSizeS}; diff --git a/x-pack/plugins/lens/public/embeddable/embeddable_info_badges.tsx b/x-pack/plugins/lens/public/embeddable/embeddable_info_badges.tsx index acace55c0f673..b6a8aa9a88f0d 100644 --- a/x-pack/plugins/lens/public/embeddable/embeddable_info_badges.tsx +++ b/x-pack/plugins/lens/public/embeddable/embeddable_info_badges.tsx @@ -69,8 +69,8 @@ export const EmbeddableFeatureBadge = ({ messages }: { messages: UserMessage[] } .euiButtonEmpty { padding-inline: ${euiTheme.size.xs}; } - .euiButtonEmpty__text { - margin-inline-start: ${euiTheme.size.xs}; + .euiButtonEmpty__content { + gap: ${euiTheme.size.xs}; } `} iconType="wrench" From b20ce86f552695945727359440488fc1afbd8f53 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Thu, 29 Jun 2023 14:22:05 -0700 Subject: [PATCH 13/28] [EuiButtonEmpty] Update removed modifier classes --- x-pack/plugins/osquery/cypress/e2e/all/alerts.cy.ts | 2 +- .../public/common/components/page/index.tsx | 3 +-- .../detections/components/rules/add_item_form/index.tsx | 5 +---- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/x-pack/plugins/osquery/cypress/e2e/all/alerts.cy.ts b/x-pack/plugins/osquery/cypress/e2e/all/alerts.cy.ts index a8653fd81f89d..8163078d421ab 100644 --- a/x-pack/plugins/osquery/cypress/e2e/all/alerts.cy.ts +++ b/x-pack/plugins/osquery/cypress/e2e/all/alerts.cy.ts @@ -328,7 +328,7 @@ describe('Alert Event Details', () => { cy.contains('Add to timeline investigation'); cy.contains('Save for later').click(); cy.contains('Save query'); - cy.get('.euiButtonEmpty--flushLeft').contains('Cancel').click(); + cy.get('.euiFlyoutFooter .euiButtonEmpty').contains('Cancel').click(); cy.getBySel('add-to-timeline').first().click(); cy.getBySel('globalToastList').contains('Added'); closeToastIfVisible(); diff --git a/x-pack/plugins/security_solution/public/common/components/page/index.tsx b/x-pack/plugins/security_solution/public/common/components/page/index.tsx index 635712a3559ec..3ad806beea3a4 100644 --- a/x-pack/plugins/security_solution/public/common/components/page/index.tsx +++ b/x-pack/plugins/security_solution/public/common/components/page/index.tsx @@ -52,8 +52,7 @@ export const AppGlobalStyle = createGlobalStyle<{ overflow: hidden; .expandable-top-value-button { - &.euiButtonEmpty--primary:enabled:focus, - .euiButtonEmpty--primary:focus { + &.euiButtonEmpty:focus { background-color: transparent; } } diff --git a/x-pack/plugins/security_solution/public/detections/components/rules/add_item_form/index.tsx b/x-pack/plugins/security_solution/public/detections/components/rules/add_item_form/index.tsx index 48c306a36a2eb..acfc1ca61f548 100644 --- a/x-pack/plugins/security_solution/public/detections/components/rules/add_item_form/index.tsx +++ b/x-pack/plugins/security_solution/public/detections/components/rules/add_item_form/index.tsx @@ -42,10 +42,7 @@ const MyEuiFormRow = styled(EuiFormRow)` export const MyAddItemButton = styled(EuiButtonEmpty)` margin: 4px 0px; - - &.euiButtonEmpty--small { - font-size: 12px; - } + font-size: 12px; .euiIcon { width: 12px; From 3adb12757bef74d5ff1c2bc9a78f3df25e4d3cfb Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Thu, 29 Jun 2023 16:15:41 -0700 Subject: [PATCH 14/28] [EuiButtonEmpty] Account for removed selector `.euiButtonContent__icon` is no longer in use (removed/deprecated) - asert on the data type instead --- .../context_editor/get_columns/index.test.tsx | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/x-pack/packages/kbn-elastic-assistant/impl/data_anonymization_editor/context_editor/get_columns/index.test.tsx b/x-pack/packages/kbn-elastic-assistant/impl/data_anonymization_editor/context_editor/get_columns/index.test.tsx index 1f6590d576c30..b38b026d37112 100644 --- a/x-pack/packages/kbn-elastic-assistant/impl/data_anonymization_editor/context_editor/get_columns/index.test.tsx +++ b/x-pack/packages/kbn-elastic-assistant/impl/data_anonymization_editor/context_editor/get_columns/index.test.tsx @@ -231,10 +231,8 @@ describe('getColumns', () => { ); - expect(container.getElementsByClassName('euiButtonContent__icon')[0]).toHaveAttribute( - 'data-euiicon-type', - 'eyeClosed' - ); + expect(container.querySelector('[data-euiicon-type="eyeClosed"]')).not.toBeNull(); + expect(container.querySelector('[data-euiicon-type="eye"]')).toBeNull(); }); it('displays a open eye icon when the field is NOT anonymized', () => { @@ -247,10 +245,8 @@ describe('getColumns', () => { ); - expect(container.getElementsByClassName('euiButtonContent__icon')[0]).toHaveAttribute( - 'data-euiicon-type', - 'eye' - ); + expect(container.querySelector('[data-euiicon-type="eyeClosed"]')).toBeNull(); + expect(container.querySelector('[data-euiicon-type="eye"]')).not.toBeNull(); }); it('displays Yes when the field is anonymized', () => { From 6cae2a9045ae9a23a89ccfe682bf989a720ac387 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Thu, 29 Jun 2023 14:22:43 -0700 Subject: [PATCH 15/28] Update multiple button and collapsible nav snapshots --- .../collapsible_nav.test.tsx.snap | 82 ++++++------ .../header/__snapshots__/header.test.tsx.snap | 14 +- .../screen_reader_a11y.test.tsx.snap | 20 +-- .../__snapshots__/modal_service.test.tsx.snap | 22 ++-- .../sample_data_card.test.tsx.snap | 18 +-- .../disabled_footer.test.tsx.snap | 2 +- .../install_footer.test.tsx.snap | 2 +- .../__snapshots__/remove_footer.test.tsx.snap | 8 +- .../__snapshots__/view_button.test.tsx.snap | 6 +- .../__snapshots__/header_menu.test.tsx.snap | 92 ++++++------- .../__snapshots__/list_header.test.tsx.snap | 54 ++++---- .../__snapshots__/edit_modal.test.tsx.snap | 10 +- .../__snapshots__/menu_items.test.tsx.snap | 122 +++++++++--------- .../text_with_edit.test.tsx.snap | 4 +- .../icon_button_group.test.tsx.snap | 12 +- .../impl/__snapshots__/markdown.test.tsx.snap | 27 ++-- .../dashboard_empty_screen.test.tsx.snap | 11 +- .../__snapshots__/data_view.test.tsx.snap | 99 +++++++------- .../get_render_cell_value.test.tsx | 4 +- .../__snapshots__/table_header.test.tsx.snap | 30 ++--- .../view_api_request_flyout.test.tsx.snap | 14 +- .../inspector_panel.test.tsx.snap | 15 +-- .../__snapshots__/page_template.test.tsx.snap | 2 +- .../__snapshots__/no_data_card.test.tsx.snap | 4 +- .../legend/__snapshots__/legend.test.tsx.snap | 2 +- .../api/__snapshots__/shareable.test.tsx.snap | 60 ++++----- .../__snapshots__/app.test.tsx.snap | 2 +- .../__snapshots__/settings.test.tsx.snap | 2 +- .../__snapshots__/index.test.tsx.snap | 96 +++++++------- .../__snapshots__/add_license.test.js.snap | 4 +- .../request_trial_extension.test.js.snap | 8 +- .../revert_to_basic.test.js.snap | 6 +- .../__snapshots__/start_trial.test.js.snap | 8 +- .../upload_license.test.tsx.snap | 40 +++--- .../nodes/__snapshots__/cells.test.js.snap | 4 +- .../__snapshots__/no_data.test.js.snap | 16 +-- ...screen_capture_panel_content.test.tsx.snap | 12 +- .../nav_control/nav_control_service.test.ts | 6 +- .../reset_session_page.test.tsx.snap | 4 +- .../__snapshots__/index.test.tsx.snap | 44 +++---- .../action_connectors_warning.test.tsx.snap | 12 +- .../authentications_host_table.test.tsx.snap | 53 ++++---- .../authentications_user_table.test.tsx.snap | 53 ++++---- .../flyout/__snapshots__/index.test.tsx.snap | 8 +- .../__snapshots__/index.test.tsx.snap | 2 +- .../__snapshots__/index.test.tsx.snap | 8 +- .../filter_status_button.test.tsx.snap | 6 +- .../__snapshots__/status_filter.test.tsx.snap | 18 +-- 48 files changed, 560 insertions(+), 588 deletions(-) diff --git a/packages/core/chrome/core-chrome-browser-internal/src/ui/header/__snapshots__/collapsible_nav.test.tsx.snap b/packages/core/chrome/core-chrome-browser-internal/src/ui/header/__snapshots__/collapsible_nav.test.tsx.snap index d32e7d27d6f16..a2c9d6044173b 100644 --- a/packages/core/chrome/core-chrome-browser-internal/src/ui/header/__snapshots__/collapsible_nav.test.tsx.snap +++ b/packages/core/chrome/core-chrome-browser-internal/src/ui/header/__snapshots__/collapsible_nav.test.tsx.snap @@ -22,35 +22,39 @@ Array [ style="flex-shrink: 0;" >
- + + Custom link + + + + +
@@ -62,12 +66,12 @@ Array [ style="flex-shrink: 0;" >
@@ -161,7 +165,7 @@ Array [ class=" emotion-euiAccordion__children" >
    @@ -286,7 +290,7 @@ Array [ class=" emotion-euiAccordion__children" >
    @@ -418,7 +422,7 @@ Array [ class=" emotion-euiAccordion__children" >
    @@ -533,7 +537,7 @@ Array [ class=" emotion-euiAccordion__children" >
    @@ -631,7 +635,7 @@ Array [ class=" emotion-euiAccordion__children" >
    , @@ -478,20 +477,19 @@ Object { > @@ -570,20 +568,19 @@ Object { > @@ -605,20 +602,19 @@ Object { > @@ -697,21 +693,20 @@ Object { > @@ -733,21 +728,20 @@ Object { > @@ -826,20 +820,19 @@ Object { > @@ -861,20 +854,19 @@ Object { > diff --git a/packages/kbn-securitysolution-exception-list-components/src/list_header/__snapshots__/list_header.test.tsx.snap b/packages/kbn-securitysolution-exception-list-components/src/list_header/__snapshots__/list_header.test.tsx.snap index c5b380bef6737..7047f3b013528 100644 --- a/packages/kbn-securitysolution-exception-list-components/src/list_header/__snapshots__/list_header.test.tsx.snap +++ b/packages/kbn-securitysolution-exception-list-components/src/list_header/__snapshots__/list_header.test.tsx.snap @@ -73,7 +73,7 @@ Object { >
    @@ -62,7 +61,7 @@ Object { >
    @@ -138,7 +136,7 @@ Object { >
    @@ -753,7 +750,7 @@ Object { >
    @@ -931,7 +927,7 @@ Object { >
    @@ -1053,7 +1048,7 @@ Object { class="euiFlexItem emotion-euiFlexItem-grow-1" >
    @@ -1148,7 +1142,7 @@ Object { class="euiFlexItem emotion-euiFlexItem-grow-1" >
    @@ -346,23 +345,22 @@ Array [ class="euiPopover__anchor css-16vtueo-render" >
    @@ -385,7 +383,7 @@ Array [
@@ -525,7 +522,7 @@ Array [ class="euiPopover__anchor css-16vtueo-render" >
@@ -689,23 +685,22 @@ Array [ class="euiPopover__anchor css-16vtueo-render" >
@@ -728,7 +723,7 @@ Array [
"` + `"
100
"` ); }); @@ -155,7 +155,7 @@ describe('Discover grid cell rendering', function () { /> ); expect(component.html()).toMatchInlineSnapshot( - `"
100
"` + `"
100
"` ); findTestSubject(component, 'docTableClosePopover').simulate('click'); expect(closePopoverMockFn).toHaveBeenCalledTimes(1); diff --git a/src/plugins/discover/public/components/doc_table/components/table_header/__snapshots__/table_header.test.tsx.snap b/src/plugins/discover/public/components/doc_table/components/table_header/__snapshots__/table_header.test.tsx.snap index cf539f43b39f4..22e4b3a0d9657 100644 --- a/src/plugins/discover/public/components/doc_table/components/table_header/__snapshots__/table_header.test.tsx.snap +++ b/src/plugins/discover/public/components/doc_table/components/table_header/__snapshots__/table_header.test.tsx.snap @@ -31,7 +31,7 @@ exports[`TableHeader with time column renders correctly 1`] = ` > diff --git a/src/plugins/kibana_react/public/page_template/__snapshots__/page_template.test.tsx.snap b/src/plugins/kibana_react/public/page_template/__snapshots__/page_template.test.tsx.snap index 38b09264c4f81..4dea9549670f3 100644 --- a/src/plugins/kibana_react/public/page_template/__snapshots__/page_template.test.tsx.snap +++ b/src/plugins/kibana_react/public/page_template/__snapshots__/page_template.test.tsx.snap @@ -370,7 +370,7 @@ exports[`KibanaPageTemplate render solutionNav 1`] = ` "`; -exports[`VisLegend Component Legend open should match the snapshot 1`] = `"
"`; +exports[`VisLegend Component Legend open should match the snapshot 1`] = `"
"`; diff --git a/x-pack/plugins/canvas/shareable_runtime/api/__snapshots__/shareable.test.tsx.snap b/x-pack/plugins/canvas/shareable_runtime/api/__snapshots__/shareable.test.tsx.snap index b8d7412279336..d294af758d489 100644 --- a/x-pack/plugins/canvas/shareable_runtime/api/__snapshots__/shareable.test.tsx.snap +++ b/x-pack/plugins/canvas/shareable_runtime/api/__snapshots__/shareable.test.tsx.snap @@ -180,7 +180,7 @@ exports[`Canvas Shareable Workpad API Placed successfully with default propertie >
"`; +exports[` App renders properly 1`] = `"
markdown mock
markdown mock
My Canvas Workpad
"`; diff --git a/x-pack/plugins/canvas/shareable_runtime/components/footer/settings/__snapshots__/settings.test.tsx.snap b/x-pack/plugins/canvas/shareable_runtime/components/footer/settings/__snapshots__/settings.test.tsx.snap index 5e66854d82bb2..a51ccfc876c79 100644 --- a/x-pack/plugins/canvas/shareable_runtime/components/footer/settings/__snapshots__/settings.test.tsx.snap +++ b/x-pack/plugins/canvas/shareable_runtime/components/footer/settings/__snapshots__/settings.test.tsx.snap @@ -323,7 +323,7 @@ exports[` can navigate Autoplay Settings 2`] = ` class="euiFormRow__fieldWrapper" > "`; +exports[`ResetSessionPage renders as expected 1`] = `"ElasticMockedFonts

You do not have permission to access the requested page

Either go back to the previous page or log in as a different user.

Log in as different user
"`; -exports[`ResetSessionPage renders as expected with custom page title 1`] = `"My Company NameMockedFonts

You do not have permission to access the requested page

Either go back to the previous page or log in as a different user.

Log in as different user
"`; +exports[`ResetSessionPage renders as expected with custom page title 1`] = `"My Company NameMockedFonts

You do not have permission to access the requested page

Either go back to the previous page or log in as a different user.

Log in as different user
"`; diff --git a/x-pack/plugins/security_solution/public/common/components/import_data_modal/__snapshots__/index.test.tsx.snap b/x-pack/plugins/security_solution/public/common/components/import_data_modal/__snapshots__/index.test.tsx.snap index fb4ab2f2da706..52a8bab60b5de 100644 --- a/x-pack/plugins/security_solution/public/common/components/import_data_modal/__snapshots__/index.test.tsx.snap +++ b/x-pack/plugins/security_solution/public/common/components/import_data_modal/__snapshots__/index.test.tsx.snap @@ -20,7 +20,7 @@ Object { > @@ -420,7 +419,7 @@ exports[`Authentication Host Table Component rendering it renders the host authe @@ -420,7 +419,7 @@ exports[`Authentication User Table Component rendering it renders the user authe