[Discover] Copy column's display name instead of original name from context menu actions #139615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontext menu actions
jughosta
added
Feature:Discover
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @jughosta |
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
kertal
approved these changes
Aug 30, 2022
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jughosta
added a commit
to jughosta/kibana
that referenced
this pull request
Aug 30, 2022
…ontext menu actions (elastic#139615) * [Discover] Copy column's display name instead of original name from context menu actions * [Discover] Update tests * [Discover] Update tests (cherry picked from commit d431e87) # Conflicts: # src/plugins/discover/public/components/discover_grid/discover_grid_columns.tsx
jughosta
added a commit
that referenced
this pull request
Aug 30, 2022
…from context menu actions (#139615) (#139702) * [Discover] Copy column's display name instead of original name from context menu actions (#139615) * [Discover] Copy column's display name instead of original name from context menu actions * [Discover] Update tests * [Discover] Update tests (cherry picked from commit d431e87) # Conflicts: # src/plugins/discover/public/components/discover_grid/discover_grid_columns.tsx * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' Co-authored-by: kibanamachine <[email protected]>
Mpdreamz
pushed a commit
to Mpdreamz/kibana
that referenced
this pull request
Sep 6, 2022
…ontext menu actions (elastic#139615) * [Discover] Copy column's display name instead of original name from context menu actions * [Discover] Update tests * [Discover] Update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #137635
Summary
This PR copies a column's display name in "Copy name" and "Copy column" actions in columns context menu. Previously it used a column's original name.
Also this PR fixes and makes sure that we show a custom field name in column title instead of an original field name elastic/eui#6013
Checklist