Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devtools] Clicking into devtools noops when console is disabled #9889

Closed
epixa opened this issue Jan 16, 2017 · 7 comments
Closed

[devtools] Clicking into devtools noops when console is disabled #9889

epixa opened this issue Jan 16, 2017 · 7 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature Feature:Dev Tools stalled Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@epixa
Copy link
Contributor

epixa commented Jan 16, 2017

Kibana version: master

Elasticsearch version: master

Server OS version: darwin

Browser version: Chrome

Browser OS version: 55.0.2883.95

Original install method (e.g. download page, yum, from source, etc.): source

Description of the problem including expected versus actual behavior:

Steps to reproduce:

  1. Run Kibana with x-pack so search profiler is in dev tools
  2. Disable console via kibana.yml
  3. Click on dev tools app

Expected: Loads the search profiler
Actual: Navigates back to discover regardless of what app you were on before

Errors in browser console (if relevant):

Object {CourierFetchRequestStatus: "aborted"}

@epixa epixa added Feature:Dev Tools bug Fixes for quality problems that affect the customer experience labels Jan 16, 2017
@epixa
Copy link
Contributor Author

epixa commented Jan 16, 2017

@jbudz Can you take a look at this when you get a chance? It'll become much more common to encounter this when we ship tribe.

@jbudz jbudz self-assigned this Jan 16, 2017
@tylersmalley
Copy link
Contributor

This is due to linkToLastSubUrl. When you last visit Console before disabling it, Kibana will try to redirect to Console then eventually redirect to Discovery due to the route not existing.

@epixa, any reason we can't disable this functionality for Dev Tools?

@epixa
Copy link
Contributor Author

epixa commented Jan 17, 2017

I'm all for this not existing in DevTools.

@spalger
Copy link
Contributor

spalger commented Jun 7, 2017

We attempted to solve this in #9912 but time constraints have caused it to stall. I've closed the PR but the changes should be valid in the future when we're ready to pick it back up again.

@tbragin tbragin added the Feature:Console Dev Tools Console Feature label Dec 8, 2017
@cjcenizal
Copy link
Contributor

When we pick this up again we should backport this a few versions. This bug goes back to at least 6.2.

@cjcenizal cjcenizal added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more and removed :Management DO NOT USE labels Jun 14, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@epixa epixa removed the PR sent label Jul 24, 2019
@jloleysens
Copy link
Contributor

Tested this on current master and it appears to be fixed. Not exactly sure on which version this was fixed. Possibly this PR #49349. Which would mean all versions that have planned releases should contain the fix.

Closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature Feature:Dev Tools stalled Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

8 participants