-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Delete" and "Copy to Space" returns errors for hidden saved object types in Saved Object Management Page #94351
Comments
Pinging @elastic/kibana-core (Team:Core) |
Just to clarify I'm assuming we should not show them since this flag only enables exporting/importing them correct? CC @pgayvallet |
I would expect it to be disabled or hidden for |
That's a good question. We're probably good just hiding the actions from the UI, as least short time to address the issue. Now, functionally having the ability to delete hidden SOs from SOM may make sense, now that we are displaying them anyway. It would require to use our own Not sure about |
Ideally I think we should enable this, but realistically I think we should hide the actions for the time being. Copy-to-space uses import/export behind the scenes, and I'm not sure what this experience should look like with the introduction of import/export hooks. IMO we should disable this functionality until we have a better understanding of how these hidden types behave under import/export, and whether we want that same behavior for copy-to-space. It's possible that we'll want to change the behavior when performing a copy. Disabling this functionality now will give us some time to investigate a proper UX for these object types. |
I'm currently working on that one, to hide/disable the unsupported actions. If disabling the Atm users can select multiple objects in the table, and then click A few options:
seems like the best compromise between implementation cost and user experience, but wdyt? |
I like this option vs disabling the button, unless we are offering the ability to somehow enable the button on the modal via some action? Otherwise, the user would have to close the modal and figure out on her own which ones can and can't be deleted. Maybe the warning could just tell them that some of the selected objects are not deletable and then clicking the "Delete" button will just delete the deletable ones? |
After discussing it with my 'personal UX guy', seems like this is the expected UX behavior. Will do that then |
For this issue, the alerting team would like to make the hidden saved object types
action
andalert
importable/exportable. SettingimportableAndExportable: true
makes them show up in the Saved Object Management page and allows use to import and export. However, the "Delete" and "Copy to Space" buttons are also enabled for these types.Clicking "Delete" gives a 404 Not Found error and a loading screen that doesn't go away.
Clicking "Copy to Space" gives a 500 internal server error.
The text was updated successfully, but these errors were encountered: