-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Anomaly detection wizard validation should run a datafeed _preview #93771
Comments
Pinging @elastic/ml-ui (:ml) |
I noticed this while creating a datafeed + job in the Adv. Wizard. I am not sure if all the wizards use the same validation path or not. |
The preview could be called as part of the validation step but seeing as the JSON can be edited on the very last step of the wizard, after the validation, it might make sense to run the preview automatically when the user saves changes to the JSON. Also it's worth noting, the |
Ah, it would be good to add a preview like that. |
@jgowdyelastic take a look at the new With a valid job (with detectors, and datafeed, etc.) the true preview is now available. Would be cool to add a preview action in the wizard after the job is created (or while it is being created). And definitely one in the validation window (that shows the true data preview and any errors) |
Describe the feature:
At the end of the wizards before the job is created, a datafeed
_preview
should be ran as part of the validations. This will catch bad queries + aggs as the user is not REQUIRED to preview their data after modifying the JSON directly.Describe a specific use case for the feature:
If the user modifies the datafeed JSON directly to add custom aggregations, there is no validation of the changes unless the user refreshes their data preview themselves. It would be good to capture these silly syntax mistakes before trying to create the datafeed.
The text was updated successfully, but these errors were encountered: