Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover][EuiDataGrid] Restore ability to compare documents #93453

Closed
kertal opened this issue Mar 3, 2021 · 3 comments
Closed

[Discover][EuiDataGrid] Restore ability to compare documents #93453

kertal opened this issue Mar 3, 2021 · 3 comments
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Mar 3, 2021

In legacy grid you could open/expand multiple documents, and had therefore a way to compare multiple documents (sort of). In the new data grid implementation this is no longer possible. During development of the new grid we implemented a way to select documents by checkbox in a PoC style, and removed later to focus on the stable parts.

So to allow users to select and compare documents in Discover the following should be implemented:

[ ] Add a checkbox to each document, allowing users to select/deselect document (We would store selected document ids in the Browsers sessionStorage, for a first version this would work like an additional filter based on the 500 doc sample. In later interactions this could work like a document collector, so you could collect document using differers filters and queries )
[ ] Provide a button/switch to the data grids toolbar to just view this selected documents
[ ] Provide a navigation for users to navigate between open documents (PR #94439)

It could look like this:

Discover___eCommerce__Orders_-_Elastic

This would allow users to compare documents and fields in a already better way than in legacy word

  • Would solve: Picking some documents to compare of a large set
  • Wouldn't solve: Expanding all documents of a small set, to get an overview
@kertal kertal added Feature:Discover Discover Application enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal
Copy link
Member Author

kertal commented Mar 17, 2021

PR #94439 adds document navigation in the flyout, so users don't need to expand multiple documents like in the legacy world

@timroes timroes added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 31, 2021
@kertal
Copy link
Member Author

kertal commented Aug 2, 2022

This was already implemented, closing this

@kertal kertal closed this as completed Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

3 participants