Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display indicator in the UI about whether a document is saved, unsaved, or in the process of saving #8886

Closed
cjcenizal opened this issue Oct 29, 2016 · 3 comments
Labels
release_note:enhancement Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Oct 29, 2016

Changes

We need to surface an indication in each app's UI about whether a document is saved, unsaved, or saving. This makes people aware as to whether the URL is an accurate reflection of the state of the document, and whether or not people will see what they see when they copy/paste the URL to someone else.

Implementation

We have plugins such as Reporting which need to know whether a state is "dirty" or not, i.e. has it been edited but not yet saved (#8148). We could use this existing functionality to update the UI with the correct state.

See #7899 (comment) for thoughts about refactoring this functionality.

@cjcenizal cjcenizal changed the title Surface saved state in the UI Display indicator in the UI about whether a document is saved, unsaved, or in the process of saving Oct 29, 2016
@cjcenizal cjcenizal added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Nov 3, 2016
@trevan
Copy link
Contributor

trevan commented Jan 2, 2017

Would a little "Modified" text string next to the title work? I'd be up to making the small change to show a modified string or icon next to the title based on the dirty flag.

@cjcenizal
Copy link
Contributor Author

@trevan I really like that idea. I think we need to wait on #9508 first though, which is reworking the view/editing UX. In fact, we could address this ticket as part of that PR.

@gchaps
Copy link
Contributor

gchaps commented Oct 5, 2018

Closing this issue. The design team is doing housekeeping against our attached tags and closing issues without much recent activity. Feel free to reopen if you still have issues or feel this is in error.

Dashboard has view and edit modes.

@gchaps gchaps closed this as completed Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:enhancement Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

No branches or pull requests

3 participants