Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generating PDF for Canvas workpads leaves a white space #85864

Closed
poffdeluxe opened this issue Dec 14, 2020 · 4 comments · Fixed by #87253
Closed

Generating PDF for Canvas workpads leaves a white space #85864

poffdeluxe opened this issue Dec 14, 2020 · 4 comments · Fixed by #87253
Labels
blocker bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Feature:Canvas v7.11.0

Comments

@poffdeluxe
Copy link
Contributor

poffdeluxe commented Dec 14, 2020 •
edited
Loading

Kibana version:
7.11

Describe the bug:
When generating a PDF in Canvas, no matter what mode I use, the PDF with the workpad contains a white strip at the bottom.

Steps to reproduce:

  1. Install ecomm sample data
  2. Go to ecomm workpad
  3. Export as PDF

Expected behavior:
The bottom of the PDF is not cut off

Screenshots (if relevant):
kip1tr8f0nx09d00627wvbsd
@poffdeluxe poffdeluxe added bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Feature:Canvas labels Dec 14, 2020
@poffdeluxe
Copy link
Contributor Author

Seems like this might be caused by #85066
Tracked it all the way back in to that commit.

This puppeteer issue might be relevant: puppeteer/puppeteer#5410

@timductive
Copy link
Member

@elastic/kibana-app-services is this on your radar?

@poffdeluxe
Copy link
Contributor Author

Did some more digging and it appears the issue comes from the fact that the clip behavior was changed in new Puppeteer. It won't clip any content that is outside of the set viewport. If I manually set the viewport to be something ridiculous like 8000x8000, the workpad PDF is generated without the white bar.

@tsullivan
Copy link
Member

Working on this now. Hope to have a fix within the next day.

@poffdeluxe poffdeluxe mentioned this issue Jan 4, 2021
Closed
@tsullivan tsullivan mentioned this issue Jan 4, 2021
Merged
2 tasks
@tsullivan tsullivan mentioned this issue Feb 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Feature:Canvas v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Reporting] set viewport to include clip area tsullivan/kibana
4 participants
@clintandrewhall @poffdeluxe @tsullivan @timductive