Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime UI] Overview tab is not selected #85826

Closed
katrin-freihofner opened this issue Dec 14, 2020 · 5 comments · Fixed by #86296
Closed

[Uptime UI] Overview tab is not selected #85826

katrin-freihofner opened this issue Dec 14, 2020 · 5 comments · Fixed by #86296
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test-plan test-plan-ok issue has passed test plan v7.11.0 v7.12.0

Comments

@katrin-freihofner
Copy link
Contributor

This issue came up in a recent design audit.

Describe the bug:
When navigating to the monitor detail page, there's no indication of which page is active in the main navigation.

Screenshots (if relevant):
Screenshot 2020-12-10 at 09 25 26

Tested master branch running locally.

@katrin-freihofner katrin-freihofner added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Dec 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@paulb-elastic paulb-elastic added v7.11.0 bug Fixes for quality problems that affect the customer experience [zube]: Ready and removed bug Fixes for quality problems that affect the customer experience labels Dec 15, 2020
@paulb-elastic
Copy link
Contributor

I think this is because you are no longer in the Overview page but have drilled down to the monitor detail page (i.e. the top navigation relates to the main Uptime page, so there is no page to highlight in the top for monitor detail). Is that right @shahzad31?

@katrin-freihofner / @formgeist what would you want to show as highlighted here (I'm not sure that Overview would be correct, as that's a different page, taking you back to the main Uptime page)?

@shahzad31
Copy link
Contributor

Yeah this is tricky, i guess we can hide tabs on all details page and move heading in place of tabs, the way it was earlier.

I kept tabs, so that user can navigate to overview/settings/certs etc from any page. But since that doesn't seems like an ideal workflow, it make sense to hide them.

Though user can navigate using breadcrumbs as well. To previous pages.

@formgeist
Copy link
Contributor

My preference probably is to not have the tabs navigation in the detail page and rely on the breadcrumbs to navigate back to the Overview and get the Monitors list. The navigation is bound to change over the next iterations, so I see this mainly as a quick fix to not have a "confusing" layout.

@katrin-freihofner thoughts on whether to remove or keep the navigation tabs?

@katrin-freihofner
Copy link
Contributor Author

My preference probably is to not have the tabs navigation in the detail page and rely on the breadcrumbs to navigate back to the Overview and get the Monitors list. The navigation is bound to change over the next iterations, so I see this mainly as a quick fix to not have a "confusing" layout.

@katrin-freihofner thoughts on whether to remove or keep the navigation tabs?

Yes, I agree. I was just about to propose the same. No tabs on the details view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test-plan test-plan-ok issue has passed test plan v7.11.0 v7.12.0
Projects
None yet
6 participants