-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime UI] Overview tab is not selected #85826
Comments
Pinging @elastic/uptime (Team:uptime) |
I think this is because you are no longer in the Overview page but have drilled down to the monitor detail page (i.e. the top navigation relates to the main Uptime page, so there is no page to highlight in the top for monitor detail). Is that right @shahzad31? @katrin-freihofner / @formgeist what would you want to show as highlighted here (I'm not sure that Overview would be correct, as that's a different page, taking you back to the main Uptime page)? |
Yeah this is tricky, i guess we can hide tabs on all details page and move heading in place of tabs, the way it was earlier. I kept tabs, so that user can navigate to overview/settings/certs etc from any page. But since that doesn't seems like an ideal workflow, it make sense to hide them. Though user can navigate using breadcrumbs as well. To previous pages. |
My preference probably is to not have the tabs navigation in the detail page and rely on the breadcrumbs to navigate back to the Overview and get the Monitors list. The navigation is bound to change over the next iterations, so I see this mainly as a quick fix to not have a "confusing" layout. @katrin-freihofner thoughts on whether to remove or keep the navigation tabs? |
Yes, I agree. I was just about to propose the same. No tabs on the details view. |
This issue came up in a recent design audit.
Describe the bug:
When navigating to the monitor detail page, there's no indication of which page is active in the main navigation.
Screenshots (if relevant):
Tested master branch running locally.
The text was updated successfully, but these errors were encountered: