Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alerting][actions] change isESOUsingEphemeralEncryptionKey determination #80678

Closed
pmuellr opened this issue Oct 15, 2020 · 5 comments
Closed
Assignees
Labels
blocker Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0

Comments

@pmuellr
Copy link
Member

pmuellr commented Oct 15, 2020

See issue #79943 (comment) .

If we end up implementing the proposed behavior in that issue of making the ESO plugin optional, and having it disable itself if the encryption key isn't set, we'll need to change the logic in the actions and alerts plugins to accomodate.

Presumably we'll change the internal properties we're using isESOUsingEphemeralEncryptionKey to reflect the new processing, perhaps something like isESOavailable or such.

@pmuellr pmuellr added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Oct 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote
Copy link
Contributor

Some potential challenges in regards to migrations: #79943 (comment)

@azasypkin
Copy link
Member

Hey @elastic/kibana-alerting-services,

Can you please confirm that you're still targeting 7.12 for this work? Once you merge your part we'll remove usingEphemeralEncryptionKey from the EncryptedSavedObjects plugin contract in #81511.

Thanks!

@mikecote
Copy link
Contributor

@azasypkin yup, I can confirm this issue made it part of our 7.12 release planning. Once this issue closes, you'll be good to go on your end 👍

@YulNaumenko
Copy link
Contributor

Closing in favor of the PR which replaces isESOUsingEphemeralEncryptionKey with isESOCanEncrypt based on the new ESO property canEncrypt.
Opened related issue which will cover the second part of the story about handling migrations.

@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0
Projects
None yet
6 participants