Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support flag for disabling prettier when running eslint CLI #79384

Closed
spalger opened this issue Oct 3, 2020 · 1 comment
Closed

Support flag for disabling prettier when running eslint CLI #79384

spalger opened this issue Oct 3, 2020 · 1 comment
Labels
Team:Operations Team label for Operations Team

Comments

@spalger
Copy link
Contributor

spalger commented Oct 3, 2020

When running ESLint from the command line it takes a whole lot of time to run. There are two things I think we could do to improve things:

  1. Help disabling prettier by adding support for --no-prettier which would be converted to --rules {"prettier/prettier": "off} in the ESLint wrapper

  2. Parallelize eslint execution. eslint-parallel is a simple project to do this, and esprint is a similar project, which runs a server in the background to maintain results and make eslint across the whole project nearly instant.

Tackling option 1 seems pretty simple, but devs would have to opt into disabling prettier and would get only a subset of the results they would get from CI, so I'm not in love with this idea.

Option 2 seems like a more correct solution, just need to evaluate some of the options.

@spalger spalger added the Team:Operations Team label for Operations Team label Oct 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley tylersmalley added 1 and removed 1 labels Oct 11, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Oct 12, 2021
@tylersmalley tylersmalley removed loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. EnableJiraSync labels Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Operations Team label for Operations Team
Projects
None yet
Development

No branches or pull requests

3 participants