Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service map anomaly indicators appear inconsistently #65403

Closed
bmorelli25 opened this issue May 6, 2020 · 2 comments · Fixed by #65882
Closed

Service map anomaly indicators appear inconsistently #65403

bmorelli25 opened this issue May 6, 2020 · 2 comments · Fixed by #65882
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:APM - DEPRECATED Use Team:obs-ux-infra_services.

Comments

@bmorelli25
Copy link
Member

bmorelli25 commented May 6, 2020

It looks like all of the Service map anomaly indicators only show up when viewing the Services Overview Service map.

For example, I have them active for Node, Ruby, and Java. You can see that on the Service Overview Service map:

Screen Shot 2020-05-05 at 5 17 03 PM

When viewing the Opbeans Node Service map, you can see it's active for Node:

Screen Shot 2020-05-05 at 5 10 50 PM

However, when viewing the Opbeans Java Service map, the Node and Ruby anomaly indicators do not show up, and I'm instead shown the setup text.

Screen Shot 2020-05-05 at 5 11 24 PM

The same thing happens with the Java and Node anomaly indicators when viewing the Ruby Service map.

I'd expect to be able to see all active anomaly indicators on all Service maps. This is in master.

@bmorelli25 bmorelli25 added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label May 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@bmorelli25 bmorelli25 added the bug Fixes for quality problems that affect the customer experience label May 6, 2020
@bmorelli25
Copy link
Member Author

For some services, I can't get the anomaly detection to show up anywhere, even though the ML job is active:
Screen Shot 2020-05-05 at 5 42 30 PM

Screen Shot 2020-05-05 at 5 43 53 PM

@smith smith self-assigned this May 7, 2020
smith added a commit to smith/kibana that referenced this issue May 8, 2020
The map anomlies rings display was working on the global map and on the focused service of a focused map, but not on the other services on a focused map.

This is because we were adding the anomlies to the list of services from the initial query, but not to the list of services derived from the connections data.

Make the transformation that add anomalies happen after the derived services nodes are added.

This is done in the function that was called `dedupeConnections`, but since it does much more than dedupe connections has been renamed to `transformServiceMapResponses`.

Also make the node types extend `cytoscape.NodeDataDefinition` in order to simplify the types in the transformation (we were adding `& { id: string }` in some places which this replaces.)

Fixes elastic#65403.
smith added a commit that referenced this issue May 8, 2020
The map anomlies rings display was working on the global map and on the focused service of a focused map, but not on the other services on a focused map.

This is because we were adding the anomlies to the list of services from the initial query, but not to the list of services derived from the connections data.

Make the transformation that add anomalies happen after the derived services nodes are added.

This is done in the function that was called `dedupeConnections`, but since it does much more than dedupe connections has been renamed to `transformServiceMapResponses`.

Also make the node types extend `cytoscape.NodeDataDefinition` in order to simplify the types in the transformation (we were adding `& { id: string }` in some places which this replaces.)

Fixes #65403.
smith added a commit to smith/kibana that referenced this issue May 8, 2020
The map anomlies rings display was working on the global map and on the focused service of a focused map, but not on the other services on a focused map.

This is because we were adding the anomlies to the list of services from the initial query, but not to the list of services derived from the connections data.

Make the transformation that add anomalies happen after the derived services nodes are added.

This is done in the function that was called `dedupeConnections`, but since it does much more than dedupe connections has been renamed to `transformServiceMapResponses`.

Also make the node types extend `cytoscape.NodeDataDefinition` in order to simplify the types in the transformation (we were adding `& { id: string }` in some places which this replaces.)

Fixes elastic#65403.
smith added a commit to smith/kibana that referenced this issue May 8, 2020
The map anomlies rings display was working on the global map and on the focused service of a focused map, but not on the other services on a focused map.

This is because we were adding the anomlies to the list of services from the initial query, but not to the list of services derived from the connections data.

Make the transformation that add anomalies happen after the derived services nodes are added.

This is done in the function that was called `dedupeConnections`, but since it does much more than dedupe connections has been renamed to `transformServiceMapResponses`.

Also make the node types extend `cytoscape.NodeDataDefinition` in order to simplify the types in the transformation (we were adding `& { id: string }` in some places which this replaces.)

Fixes elastic#65403.
smith added a commit that referenced this issue May 8, 2020
The map anomlies rings display was working on the global map and on the focused service of a focused map, but not on the other services on a focused map.

This is because we were adding the anomlies to the list of services from the initial query, but not to the list of services derived from the connections data.

Make the transformation that add anomalies happen after the derived services nodes are added.

This is done in the function that was called `dedupeConnections`, but since it does much more than dedupe connections has been renamed to `transformServiceMapResponses`.

Also make the node types extend `cytoscape.NodeDataDefinition` in order to simplify the types in the transformation (we were adding `& { id: string }` in some places which this replaces.)

Fixes #65403.
smith added a commit that referenced this issue May 8, 2020
The map anomlies rings display was working on the global map and on the focused service of a focused map, but not on the other services on a focused map.

This is because we were adding the anomlies to the list of services from the initial query, but not to the list of services derived from the connections data.

Make the transformation that add anomalies happen after the derived services nodes are added.

This is done in the function that was called `dedupeConnections`, but since it does much more than dedupe connections has been renamed to `transformServiceMapResponses`.

Also make the node types extend `cytoscape.NodeDataDefinition` in order to simplify the types in the transformation (we were adding `& { id: string }` in some places which this replaces.)

Fixes #65403.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:APM - DEPRECATED Use Team:obs-ux-infra_services.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants