Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting] should pre-configured actions never return their config? #63392

Closed
pmuellr opened this issue Apr 13, 2020 · 2 comments · Fixed by #64266
Closed

[Alerting] should pre-configured actions never return their config? #63392

pmuellr opened this issue Apr 13, 2020 · 2 comments · Fixed by #64266
Assignees
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@pmuellr
Copy link
Member

pmuellr commented Apr 13, 2020

When support for pre-configured alerts landed, the UI was changed to not display their config, as this was specified in the original design to work that way. There's some question as to whether that's what we really want to do, but if it is what we want to do, then we likely need to lock down the http endpoint and action client, to not return the config settings in their "GET" APIs. Currently, they both return the config data.

@pmuellr pmuellr added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Apr 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote
Copy link
Contributor

It has been discussed at the sync that we shouldn't return the config for now and that we'll wait for user feedback before creating an issue to display the config values.

This issue is now scoped to not return the config from the action APIs (get and getAll).

@YulNaumenko YulNaumenko self-assigned this Apr 22, 2020
@YulNaumenko YulNaumenko changed the title [Alerting] should pre-configured alerts never return their config? [Alerting] should pre-configured actions never return their config? Apr 22, 2020
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants