Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard ES UI plugins against missing usageCollection dependency #63281

Open
1 of 5 tasks
cjcenizal opened this issue Apr 10, 2020 · 3 comments
Open
1 of 5 tasks

Guard ES UI plugins against missing usageCollection dependency #63281

cjcenizal opened this issue Apr 10, 2020 · 3 comments
Labels
chore Feature:New Platform Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Apr 10, 2020 •
edited
Loading

Some of our plugins declare usageCollection as an optional dependency, but internally don't type it as optional or guard against it if it's missing.
See https://github.com/elastic/kibana/pull/63255/files#diff-6d18b1d695a8432b03b362bb913fd2faR28 or Console code for an example of the kind of changes we need to make.

Apps which need to be updated:
@cjcenizal cjcenizal added chore Feature:New Platform Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Apr 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@cjcenizal
Copy link
Contributor Author

Note we can write tests per https://github.com/elastic/kibana/blob/master/src/core/TESTING.md#testing-optional-plugin-dependencies to verify these guards work as expected.

@alisonelizabeth alisonelizabeth removed the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Sep 17, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 17, 2024
@alisonelizabeth alisonelizabeth added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Sep 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Feature:New Platform Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cjcenizal @alisonelizabeth @elasticmachine