Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover pinned filters behavior inconsistent with other apps #62773

Closed
flash1293 opened this issue Apr 7, 2020 · 5 comments
Closed

Discover pinned filters behavior inconsistent with other apps #62773

flash1293 opened this issue Apr 7, 2020 · 5 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

Kibana version: master

Describe the bug: When working with pinned filters, Discover behaves a little different than Visualize and Dashboard:

  • Saving saved search with pinned filter unpins it
  • When navigating with global filter to saved search with same saved filter, filter becomes unpinned

The behavior should be unified.

Any additional context:
See also the issue and PR for fixing this in dashboard:
#62126 #62301

@flash1293 flash1293 added bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Apr 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@sulemanof
Copy link
Contributor

I suppose these opened issue are intended to establish consistency between apps :
#59811 , #59812
And the behavior between them will be the same as in Discover (but I'm not sure, whether it is right in there)

@flash1293
Copy link
Contributor Author

Good point @sulemanof. Maybe the default behaviors offered by top nav are not quite right yet (maybe due to how it's integrated). @lizozom could you have a look?

@lizozom
Copy link
Contributor

lizozom commented May 31, 2020

@flash1293 as Dashboard now uses default behaviors, the inconsistency should be gone.
Regardless, it would be nice to figure out what the optimal behavior should be.
I remember working on this with Anton, and it not being so straight forward.

@flash1293
Copy link
Contributor Author

Closing this bug as it's no longer inconsistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants