Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type naming convention #61529

Closed
arisonl opened this issue Mar 26, 2020 · 7 comments · Fixed by #61693
Closed

Type naming convention #61529

arisonl opened this issue Mar 26, 2020 · 7 comments · Fixed by #61693
Assignees
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@arisonl
Copy link
Contributor

arisonl commented Mar 26, 2020

A consistent naming convention (e.g. type/name - solution). E.g. in the following screenshot, you can't easily tell which type belongs to which solution.
naming

@arisonl arisonl added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Mar 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote
Copy link
Contributor

I noticed we have the same issue in the "Select a trigger type" section when creating an alert.

Screen Shot 2020-03-27 at 9 11 03 AM

@mikecote mikecote self-assigned this Mar 27, 2020
@mikecote
Copy link
Contributor

It was proposed by @mdefazio to group the type filter by application that owns the alert type. It was then brought up by @arisonl that we would still have UX issues in the "Select a trigger type" when creating an alert.

It seems best to simply rename the alert types for 7.7?

A starting point for renaming:

  • Error rate threshold
  • Index threshold
  • Metric threshold
  • SIEM Notification
  • SIEM Signal
  • Transaction duration threshold
  • Uptime monitor status

@bmcconaghy
Copy link
Contributor

One thought I have is that we might consider dropping "threshold" as it seems implied in many cases and having so many alerts with that in the name might be confusing.

@mikecote
Copy link
Contributor

mikecote commented Mar 27, 2020

That's true. We could just keep threshold wording for index threshold and metric threshold and drop the others:

  • Error rate
  • Index threshold
  • Metric threshold
  • SIEM Notification
  • SIEM Signal
  • Transaction duration
  • Uptime monitor status

@mdefazio
Copy link
Contributor

It seems best to simply rename the alert types for 7.7?

Makes sense.

@mikecote
Copy link
Contributor

SIEM alert types to also be sentence case, so:

  • Error rate
  • Index threshold
  • Metric threshold
  • SIEM notification
  • SIEM signal
  • Transaction duration
  • Uptime monitor status

I will move forward with this in a PR, thanks everyone!

@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants