Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest] Package settings page UI #60699

Closed
5 tasks done
jen-huang opened this issue Mar 19, 2020 · 7 comments
Closed
5 tasks done

[Ingest] Package settings page UI #60699

jen-huang opened this issue Mar 19, 2020 · 7 comments
Assignees
Labels
design Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Ingest Management:alpha1 Group issues for ingest management alpha1 Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@jen-huang
Copy link
Contributor

jen-huang commented Mar 19, 2020

CLICK TO VIEW SCREENSHOTS

Install integration
image

Installed and up-to-date integration
image

Installed and out-of-date integration
image

Uninstall integration
image

Changelog flyout
image

View in Figma
View Figma Prototype

Add package settings page that lets user install/uninstall a package and view changelog.

Skip upgrade package functionality as part of this issue.

Tasks

  • Version information
  • Add settings page
  • Add install button
  • Add uninstall button with warning modal
    • Don't allow user to uninstall the package if there are agent configurations with datasources that use that package
@jen-huang jen-huang added the Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project label Mar 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Feature:EPM)

@jen-huang jen-huang changed the title [Ingest] Package settings page UI [Ingest] Integrations settings page UI Mar 19, 2020
@jen-huang jen-huang changed the title [Ingest] Integrations settings page UI [Ingest] Integration settings page UI Mar 19, 2020
@jen-huang jen-huang changed the title [Ingest] Integration settings page UI [Ingest] Package settings page UI Mar 19, 2020
@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 26, 2020
@ph ph added the Ingest Management:alpha1 Group issues for ingest management alpha1 label Apr 2, 2020
@neptunian
Copy link
Contributor

neptunian commented Apr 6, 2020

@ruflin @jfsiii @skh

@hbharding and I have gone been on the fence for when a user that has auto updating of packages turn off clicks on a package from the package list page whether it should navigate them to latest version of the package or the package version they have installed. This is important because all the information on the package detail page will reflect the version we choose. I am leaning towards showing the latest package version and information (what is currently happening) with some kind of warning icon that they have an old version installed. This seems what you might expect from a "package manager" but I could see how it could confuse users as our experience is more personalized. I think Henry is leaning toward the opposite of linking them to the package version they have currently installed with a similar warning that they need to update. I wanted to get others opinion on this. Thanks.

@hbharding
Copy link
Contributor

hbharding commented Apr 6, 2020

image.

For reference, this is what an integration would look like if it is installed and out-of-date:

  • There is an "alert" icon next to the version number in the header area, with a hover tooltip indicating that updates are available
  • The user can only update to the latest version. The user can't select a specific version or downgrade.

Integrations which are installed and out-of-date can be found here:
image

Because integration detail pages include documentation, I think it makes sense to show the version which is in use, otherwise we might show confusing or misleading information. It's important to note that the user must opt-in to disable the auto-update feature, so it's a conscious decision on their part to use an outdated version. For instance, if I am an iPhone 7 user, I probably don't want to read the iPhone 10 user manual.

@neptunian
Copy link
Contributor

@hbharding Think I may have been misunderstanding. So if the user has an outdated Nginx package and they click on it from the "All Integrations" tab, should they still be directed to the outdated installed version or the latest available? Or only when they click on it from the "Integrations in use" tab and it is out of date? Currently we are using the same list and just filtering.

@hbharding
Copy link
Contributor

hbharding commented Apr 6, 2020

directed to the outdated installed version

To clarify, if the user has an outdated version of Nginx installed, clicking the "Nginx" card from the "Available Integrations" or from the "Integrations in use" tab would all lead to the same page.

View screenshots

image
image
image

@neptunian
Copy link
Contributor

Got it. Thanks.

@jen-huang
Copy link
Contributor Author

Closing this as the last task related to package versions is done (#64255).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Ingest Management:alpha1 Group issues for ingest management alpha1 Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

5 participants