Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Lens shimmed plugin #56726

Closed
flash1293 opened this issue Feb 4, 2020 · 1 comment · Fixed by #56976
Closed

Clean up Lens shimmed plugin #56726

flash1293 opened this issue Feb 4, 2020 · 1 comment · Fixed by #56976
Labels
Feature:Lens Feature:NP Migration Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

To make it ready for final migration, the Lens plugin has to be cleaned up.

  • Pass all dependencies / services down from the app_plugin to the setup/start methods of the other sub plugins
  • Remove unnecessary ui imports in x-pack/legacy/plugins/lens/public/app_plugin/plugin.tsx
  • Collect all necessary ui imports in legacy_imports file
  • Replace all legacy chrome usages by NP core services counterparts

Includes #55909
@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens Feature:NP Migration labels Feb 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 mentioned this issue Feb 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Lens Feature:NP Migration Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lens client side shim cleanup flash1293/kibana
2 participants
@flash1293 @elasticmachine