Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move saved object modal into new platform #55423

Closed
flash1293 opened this issue Jan 21, 2020 · 1 comment · Fixed by #56383
Closed

Move saved object modal into new platform #55423

flash1293 opened this issue Jan 21, 2020 · 1 comment · Fixed by #56383
Assignees
@maryia-lapata
Labels
Feature:NP Migration Feature:Saved Objects Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

The various functionality around the save modal for saved objects should be moved into a new NP plugin saved_objects. All consumers should be switched to the new location as well (no proxy re-export module in the old location):

  • src/legacy/ui/public/saved_objects/components/saved_object_save_modal.tsx
  • src/plugins/kibana_react/public/saved_objects
  • src/legacy/ui/public/saved_objects/show_saved_object_save_modal.tsx (switch to use core services)
@flash1293 flash1293 added Feature:Saved Objects Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:NP Migration labels Jan 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@maryia-lapata maryia-lapata self-assigned this Jan 23, 2020
@flash1293 flash1293 mentioned this issue Jan 29, 2020
Closed
@maryia-lapata maryia-lapata mentioned this issue Jan 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryia-lapata maryia-lapata

Labels
Feature:NP Migration Feature:Saved Objects Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[NP] Move saved object modal into new platform maryia-lapata/kibana
3 participants
@flash1293 @maryia-lapata @elasticmachine