-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discuss] Syncing filters & time with URL using new state management utils #55339
Comments
Pinging @elastic/kibana-app-arch (Team:AppArch) |
7 tasks
As discussed, what if FilterManager also sync _a filters to URL:
|
Dropping a note here after our session with @ppisljar and @Dosant The workflow we should strive for should be:
|
Closing together with #44151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In scope of: #54105 and #55158 AppState and GlobalState were replaced by state syncing utilities in Dashboard app. It was done "in place" without refactoring, by just replacing old angular dependant objects for new approach.
We still have to decide how to abstract syncing of Filters and Time to Url away from applications.
And also what to do with not pinned, application level filters, which are currently synced to url together with other app state information.
On this high-level diagram you can see how filters are syncing between different components in Dashboard App as of in #55158:
g
on a relation represents only "global" filtersa
- only "app" filtersg+a
- bothAs seen on a diagram syncing
g
filters to url is decoupled from other pieces and in #55158 implemented by: https://github.com/elastic/kibana/pull/55158/files#diff-5e89f9f26cbd7f233495a2e97789a306R51Looks like this piece can mostly stay as is and probably moved somewhere close to
data/
plugin.On the other syncing application filters with
a
is on application's shoulders on this point...Parent issue #44151
The text was updated successfully, but these errors were encountered: