Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design] create a pie and tree map icon chart for Lens #54291

Closed
AlonaNadler opened this issue Jan 8, 2020 · 11 comments
Closed

[Design] create a pie and tree map icon chart for Lens #54291

AlonaNadler opened this issue Jan 8, 2020 · 11 comments
Assignees
Labels
design Feature:Lens Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v7.7.0

Comments

@AlonaNadler
Copy link

We are planning to add pie and treemap charts to Lens shortly.
This issue was the first step in working on chart icon #46287

We will need design's help in creating the new chart icons

cc: @ryankeairns @cchaos

@cchaos cchaos added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v7.7.0 labels Jan 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design (Team:Design)

@cchaos
Copy link
Contributor

cchaos commented Jan 8, 2020

Time frame is 7.7

@AlonaNadler AlonaNadler changed the title [Design] create a pie icon chart for Lens , Tree maps [Design] create a pie and tree map icon chart for Lens Jan 22, 2020
@wylieconlon
Copy link
Contributor

There are actually three chart types that we can support, if we consider sunburst and donut to be separate types:

@AlonaNadler
Copy link
Author

Hey any updates on that one? Who is working on that @ryankeairns ?

@cchaos
Copy link
Contributor

cchaos commented Mar 12, 2020

Which charts are we actually designating in the chart switcher for 7.7?

@wylieconlon
Copy link
Contributor

Sunburst- multi layer pie
Donut
Treemap

@AlonaNadler
Copy link
Author

Donut can also be a sunburst isn't it?

I would add regular Pie, Donut and treemap where sunburst is a feature inside pie and donut

@wylieconlon
Copy link
Contributor

wylieconlon commented Mar 12, 2020

To break it down as far as possible, these are all of the possible options for icons we could use in the chart switcher:

Single ring

  • Donut (default in Kibana)
  • Pie
  • Treemap

Multiple ring

  • Sunburst
  • Multi-ring donut?
  • Treemap

If you want to make it more explicit when transitioning from single-ring to multi-ring, we can do that. Otherwise, we can make it so that the "rings" option supports one or more rings.

@elizabetdev
Copy link
Contributor

Hello! 👋

Here are the icons.

Preview

Screenshot 2020-03-17 at 20 43 53

Icons Design

I notice all the other icons are inside a frame of 36px x 24px so I followed the rule. They also have a 22px height:

Screenshot 2020-03-17 at 20 47 07

In case it's necessary, you can find the Figma project here

Download

The icons are already optimized and they can be download from the following link:
lens-icons-optimized.zip

@wylieconlon
Copy link
Contributor

@miukimiu Thanks!

@cchaos
Copy link
Contributor

cchaos commented Mar 17, 2020

@wylieconlon Feel free to implement the icons into your PR, or just let me know if you'd like me to tackle it.

Thanks so much @miukimiu !!!

@cchaos cchaos closed this as completed Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Feature:Lens Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v7.7.0
Projects
None yet
Development

No branches or pull requests

5 participants