Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] Table sorting broken #51888

Closed
majagrubic opened this issue Nov 28, 2019 · 5 comments · Fixed by #63699
Closed

[TSVB] Table sorting broken #51888

majagrubic opened this issue Nov 28, 2019 · 5 comments · Fixed by #63699
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) regression Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@majagrubic
Copy link
Contributor

majagrubic commented Nov 28, 2019

Kibana version: master

Elasticsearch version:

Server OS version:

Browser version: Chrome

Browser OS version: Mac OS

Original install method (e.g. download page, yum, from source, etc.): localhost

Describe the bug:
When trying to sort on one of the aggregated fields in a TSVB table, sorting is broken.

Steps to reproduce:

  1. Open TSVB > Table

  2. Select kibana_sample_data_logs as index pattern

  3. Create the following table:
    image

  4. Click on bytes -> the results are not sorted

Expected behavior:
Bytes are sorted ascending and then with another click, descending.

Screenshots (if relevant):

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:
I believe this is a regression introduced recently. I tested on 7.1.1. and it works as expected.
Tracing the code a bit, it seems that the uiState does not register new change and always returns _default_ as column:

Possibly related: #51887

@majagrubic majagrubic added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Nov 28, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@majagrubic majagrubic added Feature:TSVB TSVB (Time Series Visual Builder) regression labels Nov 28, 2019
@timroes
Copy link
Contributor

timroes commented Nov 29, 2019

Potentially related #24243 (but not sure)

@timroes timroes added the bug Fixes for quality problems that affect the customer experience label Dec 2, 2019
@qualispec
Copy link

I am experiencing this as well on Elasticsearch / Kibana 7.5.0. Is there any update on this?

@qualispec
Copy link

Is it possible to have this issue prioritized?

This issue, coupled with TSVB Table sorting in dashboards being broken (#49626), is putting the TSVB Table visualization in an unusable state.

@amita-r
Copy link

amita-r commented Apr 15, 2020

+1
Sorting is not working on Column in the data table.
Will also like to be able to sort by the 'filter-ratio' meteric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) regression Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants