-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow action config to set default param values #50255
Comments
Pinging @elastic/kibana-stack-services (Team:Stack Services) |
Orange customer is also asking for pre-fills webhook so all their message have the same template. |
Closing as won't do. |
We need this for uptime status alert, we have received multiple complaints from users since they can't set email as default connector for uptime one click toggle alerts in uptime settings. I think we should allow users to set default with option of overriding it when user is creating alert. |
To add some context: What @shahzad31 is asking for is not only the ability for the user to add a default value for the To field, but the ability to apply this default value programatically when programmatically attaching an Action to a Rule. I'm not sure how best to deliver this... we could provide some kind of getter that returns the default params, but I'd much rather we encapsulate that and attach these defaults to an action when it is missing these values. The complexity is that we still need to validate we have these params are there when the Rule is created. 🤔 |
Returned to Triage.... |
Since this is the first request for such capability, can a custom API be built into Uptime to handle this logic? It feels too soon to provide a generalized approach for this capability until we have a few use cases. It would also unblock them on such capability instead of waiting for a while. |
Adding a There's also a notion of "parameter templates" - #95049 For that one, you could imagine a customer picks an email connector, and then an email template to use with it. Presumably a solution could create/manage their own template, and use it under the covers when creating the alert. Perhaps there are default templates per rule per space.
Not sure I completely understand the context here. Example? I totally get that depending on how dynamic these values are, including being set or not, you could end up at execution time with required params not having values, or having invalid values that no longer validate. Maintaining consistency could be expensive ... is that what you mean? |
All I mean is that, in the same way that you can't create a rule in the UI without the value being there, you shouldn't be able to create a rule programatically without all values being specified. |
Yeah, there's something to that. I personally think that would give users a relatively nice UX 🤷 but I leave that to O11y PMs to decide. |
Ya, agree that we should try to do this in Uptime as Gidi/Mike suggest - maybe it's possible, or would require just a few fixes to make it work. Or maybe we'll find out something more complex is required. And perhaps we can use this to come up with a simpler way for solutions to enable this - by having something like an internal-only kind of templating facility that solutions could plug into. |
eg email action that pre-fills the to field
The text was updated successfully, but these errors were encountered: