Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools][SearchProfiler] Copy Review #49771

Closed
jloleysens opened this issue Oct 30, 2019 · 6 comments
Closed

[DevTools][SearchProfiler] Copy Review #49771

jloleysens opened this issue Oct 30, 2019 · 6 comments
Labels
Feature:Dev Tools Feature:Search Profiler Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@jloleysens
Copy link
Contributor

After merging this PR: #48795

We need to review new copy introduced under the Screenshots new section. Specifically:

  • Profiling...
  • Nothing to see here yet.
  • Enter a query and press the "Profile" button or provide profile data in the editor

CC @gchaps @alisonelizabeth

@jloleysens jloleysens added Feature:Dev Tools Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Search Profiler labels Oct 30, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@gchaps
Copy link
Contributor

gchaps commented Nov 25, 2019

Here is some text I was thinking of. Let me know what you think.

Empty state

No queries to profile
Enter a query, click Profile, and see the results here.

@miukimiu The second second above refers to an action that the user takes in the editor to the left of the panel that contains the message. Do you think we need a left-pointing arrow?

Loading message

Loading query profiles...

@cchaos
Copy link
Contributor

cchaos commented Nov 25, 2019

Tagging in @miukimiu as she's working on the UI/UX side of Search profiler. See Gail's question above.

@jloleysens
Copy link
Contributor Author

@gchaps Thanks for the copy recommendations. They sound great to me!

I suppose updates to any relevant screenshots that may be hanging around can wait until after @miukimiu 's changes.

@elizabetdev
Copy link
Contributor

@gchaps thanks for the copy. Yes, I think the action should be clickable. But I can change that when I bring the UI/UX changes (#49772) and also put a more colorful, happier empty state.

@alisonelizabeth
Copy link
Contributor

Looks like some copy improvements were made via #51700.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dev Tools Feature:Search Profiler Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

6 participants