Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add multiple filters with different case variations of the same string #49450

Closed
rayafratkina opened this issue Oct 27, 2019 · 7 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Filters impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. regression

Comments

@rayafratkina
Copy link
Contributor

rayafratkina commented Oct 27, 2019

Kibana version: 7.4

Elasticsearch version: 7.4

Browser version: Chrome

Original install method (e.g. download page, yum, from source, etc.): Cloud instance

Describe the bug:
When you have a field that has values that are the same string in different case, user is not able to create "is one of" filter to include all these values.

Steps to reproduce:

  1. state field has valued "open", "OPEN", "closed", "CLOSED"
  2. Open visualize and create new visualization
  3. Click "Add filter". Select field "state" and operator "is one of"
  4. Start typing "clos"
  • notice the display is wrong - strings overlap
  1. Select one version of the value. Start typing again.
  • no matches are displayed and there is no way to add the second version

Expected behavior:
User should be able to add both "closed" and "CLOSED" to the filter

Same issue exists on the Dashboard.

@rayafratkina rayafratkina added Feature:Filters triage_needed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 27, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@rayafratkina rayafratkina added bug Fixes for quality problems that affect the customer experience regression and removed triage_needed labels Oct 27, 2019
@nreese
Copy link
Contributor

nreese commented Oct 28, 2019

The overlapping text is because EUI combo box does not allow duplicate labels. https://elastic.github.io/eui/#/forms/combo-box

Screen Shot 2019-10-27 at 8 25 03 PM

Looks like EuiComboBox lower cases the labels so different casings for the same string is causing duplicate labels.

https://github.com/elastic/eui/blob/master/src/components/combo_box/combo_box_options_list/combo_box_options_list.js#L269

@timroes timroes added Team:AppArch and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lizozom
Copy link
Contributor

lizozom commented Jul 5, 2020

Reproduced on master.

@elastic/kibana-design is it possible to add an option to make the ComboBox component case sensitive? i.e. to allow adding "Closed" and "CLOSED" as two separate items?

If not, we'd have to hack it ;-)

@lizozom lizozom added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. triaged labels Jul 5, 2020
@cchaos
Copy link
Contributor

cchaos commented Jul 6, 2020

@lizozom There isn't currently, but you can open an issue in the EUI repo.

@lizozom
Copy link
Contributor

lizozom commented Jul 9, 2020

@cchaos done elastic/eui#3718

@lizozom
Copy link
Contributor

lizozom commented Oct 6, 2020

Closing this issue, duplicate of EUI issue @cchaos attached.
elastic/eui#1997

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Filters impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. regression
Projects
None yet
Development

No branches or pull requests

6 participants