Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation icons do not match new iconography in 6.5, 6.x and master #24845

Closed
alexfrancoeur opened this issue Oct 30, 2018 · 11 comments
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v6.5.1 v7.0.0

Comments

@alexfrancoeur
Copy link

alexfrancoeur commented Oct 30, 2018

icons missing

The navigation icons does not match the new standard icon design has come up with. Can we update these?

cc: @rashidkpc

@alexfrancoeur alexfrancoeur added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Oct 30, 2018
@cqliu1 cqliu1 added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Oct 30, 2018
@alexfrancoeur
Copy link
Author

cc: @rayafratkina

@stacey-gammon
Copy link
Contributor

I don't think this is a blocker... also no version label, so maybe you meant blocker for 7.0, not 6.5?

@alexfrancoeur
Copy link
Author

@stacey-gammon I meant 6.5. I think we need to update the nav icon to be consistent with the rest of the changes. I believe these icons are updated for 6.5 and not just master. Can we backport this change in time?

@stacey-gammon
Copy link
Contributor

cc @LeeDr - are you okay with last minute icon changes?

Can we backport this change in time?
@alexfrancoeur - has this change been merged in master and 6.x but the only question is whether to backport to 6.5? Or is this a PR that still needs to be worked on? Would the @elastic/kibana-design team work on it?

@alexfrancoeur
Copy link
Author

@stacey-gammon let me double check the snapshot to see if the new icons are in there in 6.5

@ryankeairns
Copy link
Contributor

It appears all of the icons in the left nav are the old version, not just Canvas.

@alexfrancoeur
Copy link
Author

Yup, just noticed that @ryankeairns and it is apparent in the 6.5 snapshot. Separately, we're showing Graph in Basic which is a no-no. I'll open a bug for this as well. Can we get this fixed before 6.5?

icons missing

@alexfrancoeur alexfrancoeur changed the title Canvas icons do not match in master Navigation icons do not match new iconography in 6.6, 6.x and master Nov 7, 2018
@alexfrancoeur alexfrancoeur changed the title Navigation icons do not match new iconography in 6.6, 6.x and master Navigation icons do not match new iconography in 6.5, 6.x and master Nov 7, 2018
@alexfrancoeur
Copy link
Author

I removed blocker because I know the bar is high, but we should fix this ASAP

@alexfrancoeur alexfrancoeur removed the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Nov 7, 2018
@alexfrancoeur
Copy link
Author

Definitely not a blocker. We're using iconography on the homepage in 6.4 that is different than the nav. Still a bug, definitely not a blocker

@snide snide self-assigned this Nov 7, 2018
@snide
Copy link
Contributor

snide commented Nov 7, 2018

Assigned myself. May not get to it by 6.5, but I'll get it in master for sure.

@spalger spalger added v6.5.1 and removed v6.5.0 labels Nov 14, 2018
@cchaos
Copy link
Contributor

cchaos commented Jan 16, 2019

@cchaos cchaos closed this as completed Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v6.5.1 v7.0.0
Projects
None yet
Development

No branches or pull requests

7 participants