-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] ML integration will not work on Basic license #24486
Comments
Pinging @elastic/apm-ui |
@blaklaybul what do you recommend? |
@makwarth @formgeist it's worth you checking out the changes we made to the way the license is checked when the ML plugin loads up as part of #24423, specifically in You'll need to check if the license is platinum or trial, and that the license is active (i.e. not expired) and that the ML feature of x-pack license info is enabled. For a basic or gold license, the ML plugin is now enabled, but only the Data Visualizer is available. |
@peteharverson Thanks for the reply, and the reference – @elastic/apm-ui anyone want to grab this and see about changing the check in the Integrations context menu? |
@formgeist How did you figure out it was due to license issues? |
@sqren Because ML is available but limited with a basic license, and I thought we checked just whether or not ML is available in Kibana, and not whether or not it's running the appropriate license we need to create APM jobs. |
I've create a separate ticket for the This ticket is now more related to updating the Integration to consider which license is enabled, so we can expect ML to be able to create jobs or we have to throw an error that the license is not platinum and therefore the integration does not work. |
There are other checks we should be doing, related to permission - #20728 We will keep the ML button and add a message letting the user know that they need a higher license to run it. |
cc @alvarolobato @makwarth @roncohen see: #20728 (comment) tl;dr we aren't able to use the ML method for getting privilege info outside of the ML plugin. Without that, I don't see a way to get privilege info about who can/can't create ML jobs when the license says ML is available. We suggest, for now, just updating the error message to say that the job already exists or you may not have permission to create a job, until there is a better way to know this info in advance. |
Couldn't we check if the license is |
possibly, but I think we were trying to avoid this kind of check because it's fragile (what if certain basic licenses are given ML job creation privileges, would we know that and update our code or would we block those users from the button forever because of our check?) -- it would be great if those granular privileges were exposed via API somehow. Since we can't check privileges right now, I'm happy to check on license type if that's what we want to do. Also happy to just update the error message like so: |
Kibana version:
Master - 7.0.0.
Any additional context:
Basic license
Update: permission checking for ML capabilities is outlined here: #20728
Updated description: We found that the
KibanaLinkComponent
was breaking our integration links, which is why the integration wasn't working. This issue is now related to checking whether the Kibana license is platinum so we can expect that ML will create a job for us. Otherwise we might have to resort to an error message telling the user that the license does no support ML anomaly detection jobs and they should upgrade.We'd prefer that the ML integration not show if license is only basic, because the user cannot use the integration properly without a platinum license.
cc @makwarth @blaklaybul
AC:
Note:
The text was updated successfully, but these errors were encountered: