Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: simplify interactions between AppState, Global State, URL and Redux State #21701

Closed
stacey-gammon opened this issue Aug 6, 2018 · 0 comments · Fixed by #97941
Closed
Labels
chore Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@stacey-gammon
Copy link
Contributor

This is a common source of bugs. Historically, when dashboard was written all in angular, it used AppState and the URL to handle state updates. When we started transitioning to redux and react, dashboard was one of the first to make the move.

"dashboard_state_manager" was created to bridge the gap between Redux state, and the URL which is managed by AppState and GlobalState objects.

Goal

Remove dependency on AppState and GlobalState objects letting redux handle syncing the URL.

Pre Req TODOs

  • Investigate best ways to handle URL syncing in the redux world. Do we introduce react-redux-router, react-router or try to do something manually? Note: APM did some work here, would be worthwhile to sync with them.
  • Investigate how the interaction will work if embeddables modify core components, like the time picker, directly. Does the flow go embeddable -> time picker -> url -> react router? I think listening to URL changes should be sufficient, but it will require some digging to be sure.
@stacey-gammon stacey-gammon added chore Feature:Dashboard Dashboard related features :Sharing labels Aug 6, 2018
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed :Sharing labels Sep 13, 2018
@timroes timroes added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants