Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Delete route handlers for deprecated bulk endpoints #208329

Open
2 tasks done
Tracked by #200310
nikitaindik opened this issue Jan 27, 2025 · 4 comments · May be fixed by #213426
Open
2 tasks done
Tracked by #200310

[Security Solution] Delete route handlers for deprecated bulk endpoints #208329

nikitaindik opened this issue Jan 27, 2025 · 4 comments · May be fixed by #213426
Assignees
Labels
8.18 candidate Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture v9.0.0 v9.1.0

Comments

@nikitaindik
Copy link
Contributor

nikitaindik commented Jan 27, 2025

Previous work for context: #193184

Summary

We have unregistered the deprecated bulk endpoints from router in main/v9. Now we need to fully remove the code.

AC:

  • Deprecated bulk endpoint handlers should be removed from main and v9 branches (but they should stay in v8)
  • Related tests, unused utils and any other dead code should be removed

List of deprecated bulk endpoints

Method Endpoint
POST /api/detection_engine/rules/_bulk_create
PUT /api/detection_engine/rules/_bulk_update
PATCH /api/detection_engine/rules/_bulk_update
DELETE /api/detection_engine/rules/_bulk_delete
POST /api/detection_engine/rules/_bulk_delete

Todo

  • Delete the route handlers and all the associated code
  • Address TODO: https://github.com/elastic/kibana/issues/193184 comments
@nikitaindik nikitaindik added Feature:Rule Management Security Solution Detection Rule Management area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team technical debt Improvement of the software architecture and operational architecture triage_needed labels Jan 27, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@banderror
Copy link
Contributor

banderror commented Mar 6, 2025

@jkelas This is another issue related to the removed bulk CRUD endpoints.

Besides removing the docs for the bulk CRUD API, we will need to clean up the code and remove the bulk CRUD handlers, as well as any leftover code related to them, so that we don't leave any unused code in the repo. I guess this was already on you list to do.

I added this ticket to the epic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.18 candidate Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture v9.0.0 v9.1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants