Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Tags filter in updates table does not reflect newly added tags #206655

Closed
Tracked by #179907
pborgonovi opened this issue Jan 14, 2025 · 5 comments
Closed
Tracked by #179907
Labels
bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. needs product Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@pborgonovi
Copy link
Contributor

Description:

When a user selects a rule with available updates in the Updates Table, adds new tags, and saves them in the Update flyout, the changes are saved locally in the flyout but the rule is not yet updated (user clicks Dismiss instead of updating the rule). Despite the new tags being added in the flyout, the Tags filter in the updates table does not include the newly added tags.

Kibana/Elasticsearch Stack version:

VERSION: 9.0.0
BUILD: 82604
COMMIT: 6ec7c37

Functional Area (e.g. Endpoint management, timelines, resolver, etc.):

Rules Update

Pre requisites:

  1. prebuiltRulesCustomizationEnabled flag is enabled
  2. Prebuilt rules are available
  3. Rules have updates available
  4. At least one rule has tags update available

Steps to reproduce:

  1. Go to the Rule Updates table.
  2. Select a rule that has an update to the Tags field.
  3. Open the Update flyout for the rule.
  4. Add new tags to the rule and save the changes.
  5. Click Dismiss in the flyout to close it without updating the rule.
  6. Check the Tags filter in the updates table.

Current behavior:

The newly added tags are not included in the Tags filter options in the updates table.

Expected behavior:

The newly added tags should be included in the Tags filter options in the updates table.

Screenshots:

Screen.Recording.2025-01-14.at.9.48.24.AM.mov
@pborgonovi pborgonovi added bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team triage_needed labels Jan 14, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@banderror
Copy link
Contributor

@pborgonovi The Rule Updates table shows the currently installed prebuilt rules that can be upgraded, and the Tags filter there aggregates the tags of these installed and stored in Elasticsearch rules. On the other hand, the Rule Upgrade flyout includes the tags that are yet to be applied to an installed prebuilt rule and yet to be saved to Elasticsearch. I'm not sure why this temporary data from the flyout should affect the table filters.

@approksiu Thoughts?

@approksiu
Copy link

I don't think we should update the (tag) filters with the data yet to be applied. It could also create odd collisions/unexpected data present for other users working on updates.
cc @banderror @pborgonovi

@banderror banderror closed this as not planned Won't fix, can't repro, duplicate, stale Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. needs product Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Development

No branches or pull requests

4 participants