Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][EUI visual refresh] change usages of success to accentSecondary #201879

Closed
PhilippeOberti opened this issue Nov 26, 2024 · 4 comments
Assignees
Labels
Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team
Milestone

Comments

@PhilippeOberti
Copy link
Contributor

PhilippeOberti commented Nov 26, 2024

Context

Changes are made to EUI that will be visible to end-users in Kibana:

  • Updated all colors in EUI
  • Reduce the topmost font weights and sizes (think titles and headings)
    These changes are available in a new theme called Borealis.

See parent ticket for how to use the new theme and labels to add to the PR for tracking

Important

Make sure that you use the backport:skip label on the PR!!

Description

All usages of "success" colors have been updated to "accentSecondary" and "textAccentSecondary" as needed.

Important

Success is changing from teal to a semantic green. We are asking all teams to now only use success to convey affirmative, semantic meaning. If you were using it as a means of displaying a teal brand color, you can continue doing so with the accentSecondary color.
Please look at each instance where you are using the "success" color.

  • If conveying some affirmative meaning - success, a positive action, etc. -- continue using the success color
  • If not -- please update the color to accentSecondary

If you are unsure, ask your assigned "Design QA" team member or the EUI Team

# previous color token -> new color token
success -> success // Semantic green conveys an affirmative meaning
success ->  accentSecondary // Teal green for non-semantic purposes; aligns to brand

An example of an affirmative meaning would be this confirmation dialog. This would use the success color:

An example of a non-affirmative meaning would be the background of the "Security" badge. This would use the accentSeoncary color.

@PhilippeOberti PhilippeOberti added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Investigations Security Solution Investigations Team labels Nov 26, 2024
@PhilippeOberti PhilippeOberti added this to the 8.18 milestone Nov 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@PhilippeOberti PhilippeOberti changed the title [Security Solution][EUI visual refresh] change usages of "success" to "accentSecondary" [Security Solution][EUI visual refresh] change usages of success to accentSecondary Nov 26, 2024
@lgestc lgestc self-assigned this Dec 17, 2024
@PhilippeOberti PhilippeOberti modified the milestones: 8.18, 9.0 Dec 27, 2024
@lgestc
Copy link
Contributor

lgestc commented Jan 22, 2025

my changes were deemed unnecessary as the current use of success seems fine (per design team)

@lgestc lgestc closed this as completed Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants