Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] When dark mode is set to system console is rendered with the wrong theme #201790

Closed
sabarasaba opened this issue Nov 26, 2024 · 5 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@sabarasaba
Copy link
Member

When having the OS darktheme enabled and kibana darkmode set to system: the editor, output and history editors are rendered with light theme

Image

@sabarasaba sabarasaba added bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Nov 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@alisonelizabeth
Copy link
Contributor

@SoniaSanzV I've asked Elena to pick this up one as you're focused on tests/remote clusters 👍

@SoniaSanzV
Copy link
Contributor

SoniaSanzV commented Jan 9, 2025

Thank you @alisonelizabeth! Just for visibility, in the short time that I spent researching this, I came to the conclusion that the problem seams to be here:

const euiTheme = darkMode ? buildDarkTheme() : buildLightTheme();

We are building the console theme relaying on the darkMode but the tag for the set to system config is always light (for both Amsterdam and Borealis). I raise a question about this to kibana-operations but I didn't get an answer and I haven't come back to it.

@SoniaSanzV
Copy link
Contributor

It was fixed in this PR

@ElenaStoeva
Copy link
Contributor

Thanks @SoniaSanzV. Closing as fixed then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

5 participants