Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLO][Fleet] Reauthorize SLO transforms #189756

Closed
mgiota opened this issue Aug 1, 2024 · 4 comments
Closed

[SLO][Fleet] Reauthorize SLO transforms #189756

mgiota opened this issue Aug 1, 2024 · 4 comments
Labels
Team:obs-ux-management Observability Management User Experience Team

Comments

@mgiota
Copy link
Contributor

mgiota commented Aug 1, 2024

Summary

As part of this PR a secondary authorization header was added to Transforms in Fleet, making the permissions/privileges dependent on the logged-in user. Previously everything was installed as kibana_system user, which has limited permissions to a specific set of indices defined internally.

When SLO assets are installed, transforms get installed as well. The secondary authorization header that was added to Transforms in Fleet, didn't automatically got applied to SLO transforms, since SLO assets are installed as kibana assets and the secondary authorization header is currently applied only to ES assets.

Thus in this PR which handles the installation of SLO assets in Fleet, we hit following permission error:

Screenshot 2024-08-01 at 22 58 59 Screenshot 2024-08-01 at 22 56 21

✅ Acceptance criteria

Adapt the SLO installation process to incorporate the Transform reauthorization process

Screenshot 2024-08-01 at 23 24 23 Screenshot 2024-08-01 at 23 25 30 Screenshot 2024-08-01 at 23 26 47 Screenshot 2024-08-01 at 23 27 00
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 1, 2024
@mgiota
Copy link
Contributor Author

mgiota commented Aug 1, 2024

I created a temp commit branched from this PR. I adapted existing Transforms Reauthorization process to take into consideration SLO transforms as well. Here's how the Reauthorization workflow looks like so far:

Screen.Recording.2024-08-01.at.16.40.39.mov

This is still WIP, since I am clarifying the workflow with Fleet team in this thread

cc @qn895

@mgiota mgiota added the Team:obs-ux-management Observability Management User Experience Team label Aug 1, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Aug 1, 2024
@kdelemme
Copy link
Contributor

I think we don't want to pursue this. @jasonrhodes can I close?

@jasonrhodes
Copy link
Member

Yes we should close, as we are not installing SLOs via integrations. This is what is supposed to be replaced by "templates" or "prepackaged assets", or whatever those end up being called. I'll link that issue to this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Development

No branches or pull requests

4 participants