Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Job Validation - model memory format check is too generous and is sometimes skipped #18764

Closed
pheyos opened this issue May 3, 2018 · 2 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml

Comments

@pheyos
Copy link
Member

pheyos commented May 3, 2018

Found in version

  • 6.3.0 b1005

Steps to reproduce

  • Create a multi metric job (e.g. for the cloudwatch dataset)
  • Provide a detector and a valid job name, but no data split
  • For Model memory limit set an invalid value (e.g. abc)
  • Validate the job => [1]
  • Add a data split
  • For Model memory limit set an invalid value of the form <number><string> or just number (e.g. 1abc or 5)
  • Validate the job => [2]

Expected result

  • [1] and [2] : The model memory format check fails and an error message is displayed in the validation results.

Actual result

  • [1] the model memory format check is skipped together with the other mml checks. This check should always be executed (as long as all basic checks are successful).
  • [2] the model memory check doesn't fail.

Additional information

  • [2] the check fails correctly for some other model memory formats, e.g. 0m, abc, 0.
@pheyos pheyos added bug Fixes for quality problems that affect the customer experience :ml labels May 3, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@pheyos
Copy link
Member Author

pheyos commented Nov 5, 2018

The issue doesn't occur in 6.5.0 any more. Closing.

@pheyos pheyos closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml
Projects
None yet
Development

No branches or pull requests

3 participants