Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Job validation doesn't check lower bound on model memory limit #18380

Closed
elasticmachine opened this issue Apr 4, 2018 · 0 comments
Closed
Assignees

Comments

@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 4, 2018

Original comment by @droberts195:

The lowest permitted model memory limit is 1MB. The backend job creation endpoint will refuse to create a job with a lower model memory limit.

The UI currently does not check for this, so if you try to create a job with a limit of 1023KB you get an error from the backend endpoint:

screen shot 2018-04-04 at 13 49 23

But clicking the "Validate Job" button in this situation gives you a tick for "Model memory limit":

screen shot 2018-04-04 at 13 52 00

The 1MB minimum is the clear-cut check that should be added to the UI validation. However, there is another soft check that could also be added: if the model memory estimator is calculating a value based on a formula rather than a simple default then warn if the value chosen by the user is less than half this amount, as the job is almost certain to then hit hard limit.


Part of #18368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants