Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless] [Unified Search] Increase minimum refresh interval to 5s. #176256

Closed
Tracked by #166211
thomasneirynck opened this issue Feb 5, 2024 · 10 comments · Fixed by #188881
Closed
Tracked by #166211

[Serverless] [Unified Search] Increase minimum refresh interval to 5s. #176256

thomasneirynck opened this issue Feb 5, 2024 · 10 comments · Fixed by #188881
Assignees
Labels
enhancement New value added to drive a business result impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@thomasneirynck
Copy link
Contributor

Describe the feature:

5s should be minimum for the refersh setting. Currently it is 1s

Describe a specific use case for the feature:

1s adds needless strain on resources. 5s is more sensible guideline.

More context here https://github.com/elastic/kibana-team/issues/745

@thomasneirynck thomasneirynck added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Feb 5, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@thomasneirynck thomasneirynck added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Feb 5, 2024
@thomasneirynck
Copy link
Contributor Author

This seems to be an eui component https://eui.elastic.co/#/forms/auto-refresh#refresh-interval, and not sure if the interval settings are configurable.

@thomasneirynck
Copy link
Contributor Author

Blocked by eui improvement elastic/eui#7512

@thomasneirynck thomasneirynck added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Feb 6, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@thomasneirynck thomasneirynck removed Team:Visualizations Visualization editors, elastic-charts and infrastructure Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Feb 6, 2024
@lukasolson
Copy link
Member

Are we talking about a minimum for the component only, or also for the refresh behavior itself?

Right now, at least in Discover, you can modify the state in the URL to even get sub-1s values (refreshInterval:(pause:!f,value:100)).

@kertal
Copy link
Member

kertal commented Feb 8, 2024

Right now, at least in Discover, you can modify the state in the URL to even get sub-1s values (refreshInterval:(pause:!f,value:100)).

Could call @lukasolson, I think we should catch such values by better validation on consumer side

@ThomThomson
Copy link
Contributor

@thomasneirynck I notice you assigned the @elastic/kibana-presentation team to this. Is the idea here that only dashboard would have this limit, and we'd need to pass a prop into the Unified Search bar? Does it also require work on the Unified Search side to allow for this prop to be passed in, and for validation to prevent sub-1s refresh intervals from being injected?

@thomasneirynck
Copy link
Contributor Author

@ThomThomson

yes, and only for Serverless. As far as team assignment, I had to pick something :)

@lukasolson

a minimum for the component only, or also for the refresh behavior itself?

Both. Dashboards should not trigger such fast refreshes in any scenario.

@thomasneirynck
Copy link
Contributor Author

Improvement merged in Eui elastic/eui#7516. Removed blocked label.

@teresaalvarezsoler teresaalvarezsoler added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Apr 30, 2024
@markov00 markov00 removed their assignment May 29, 2024
@nickofthyme nickofthyme self-assigned this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants