Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci/pull requests] Catch devDependencies used in distribution #170059

Open
jbudz opened this issue Oct 27, 2023 · 2 comments
Open

[ci/pull requests] Catch devDependencies used in distribution #170059

jbudz opened this issue Oct 27, 2023 · 2 comments
Labels
Team:Operations Team label for Operations Team

Comments

@jbudz
Copy link
Member

jbudz commented Oct 27, 2023 •
edited
Loading

Currently pull requests are tested against a distribution of Kibana, but due to our folder layout and node's module resolution, development dependencies are able to be loaded.

We have downstream checks before artifacts are promoted that will catch these errors, but it's inconveniently late in the process for contributors. We should add a check in the pull request pipeline.

Example
@jbudz jbudz added the Team:Operations Team label for Operations Team label Oct 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@Ikuni17
Copy link
Contributor

Ikuni17 commented Nov 15, 2023

This is a similar occurrence: #170852 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team:Operations Team label for Operations Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbudz @Ikuni17 @elasticmachine