Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Some MITRE ATT&CK cards cannot be read in dark mode #164866

Closed
MadameSheema opened this issue Aug 25, 2023 · 7 comments · Fixed by #164613
Closed

[Security Solution] Some MITRE ATT&CK cards cannot be read in dark mode #164866

MadameSheema opened this issue Aug 25, 2023 · 7 comments · Fixed by #164613
Assignees
Labels
8.10 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management area fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.10.0

Comments

@MadameSheema
Copy link
Member

Describe the bug:

  • Some MITRE ATT&CK cards cannot be read in dark mode

Kibana/Elasticsearch Stack version:

  • 8.10.0 BC2

Initial setup:

  • To have your Kibana instance in dark mode
  • To have all the Elastic rules installed and enabled

Steps to reproduce:

  1. Navigate to Dashboards
  2. Select MITRE ATT&CK coverage

Current behavior:

  • Some cards cannot be read
Screenshot 2023-08-25 at 18 12 46

Expected behavior:

  • The user should be able to read all the cards
@MadameSheema MadameSheema added bug Fixes for quality problems that affect the customer experience triage_needed Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team labels Aug 25, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@banderror banderror added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Feature:Rule Management Security Solution Detection Rule Management area 8.10 candidate v8.10.0 and removed triage_needed labels Aug 25, 2023
@banderror banderror removed their assignment Aug 25, 2023
@banderror
Copy link
Contributor

Should be fixed by #164613

@craig-abbott
Copy link

craig-abbott commented Aug 25, 2023

Just wading in on this in the absence of @ARWNightingale, hopefully not stepping on any toes!

I think the dark-mode issue could be fixed relatively easily provided the background colour of the cards can be $success in light-mode and $successText in dark-mode.

If so, we could create a pallet by reducing the base value to 60%, 40% and 0% against a page background of $emptyShade, and provided the primary text is $fullShade and the secondary text is $text then any variation should still pass WCAG 2.1 AA for colour contrast.

Here is an example, along side a colour contrast check between $success and text in light-mode, which has the lowest colour contrast of the whole palette. It's still above the 4.5:1 minimum.

Hope this all makes sense!

@banderror
Copy link
Contributor

Thanks @craig-abbott for the detailed suggestion. @dplumlee does it match the fix?

@banderror
Copy link
Contributor

Fixed by #164613

@banderror banderror reopened this Aug 25, 2023
@MadameSheema
Copy link
Member Author

Fixed on BC3 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.10 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management area fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.10.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants