Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Saved Objects] Investigate Cohesion and De-coupling Improvements for Repository & Security Extension #145730

Closed
3 tasks done
jeramysoucy opened this issue Nov 18, 2022 · 2 comments
Labels
Feature:Saved Objects Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@jeramysoucy
Copy link
Contributor

jeramysoucy commented Nov 18, 2022

To be considered after PR 142878 has merged.

Description

During review of PR 142878, it was identified that the cohesion/coupling between the Saved Objects Repository and the Saved Objects Security Extension should be investigated and improved.

To be considered...

It will be important to keep in mind the current flexibility we have in the current implementation which lends to improved performance and authz granularity over the previous wrapper implementations (such as reduced number of queries to elasticsearch, and per-object/type/space checks), and to refrain from compromising this in any updates.

@jeramysoucy jeramysoucy added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Saved Objects labels Nov 18, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@jeramysoucy
Copy link
Contributor Author

jeramysoucy commented Jan 9, 2023

Migration of authorization logic and audit logging is underway in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Saved Objects Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

No branches or pull requests

2 participants