[DataViews] Check if logs-*, metrics-*, apm- empty state workaround is still needed and clean up

[Dosant]

Summary:

In #108887, #110094 we added a list of hardcoded "default" assets into logic to check if this is a new instance of Kibana to show a welcome screen and present other empty states.

Since #82851 is fixed in 8.1 it is likely that we can clean up that code: remove a list of hardcoded assets completely or at least reduce number of them:

• Check if logs-*, metrics-* data view workaround is still needed as Fleet system package installs 15 Dashboards, 120+ Visualizations and 2 Kibana index-patterns #82851 is fixed
• Check if apm-* workaround is still needed original issue
• logs-enterprise_search.api-default workaround is still needed, but possibly can be addressed by ent search team cc @aznick

Relevant code:

kibana/src/plugins/data_views/server/has_user_index_pattern.ts

Lines 18 to 63 in 041b5e1

	export const hasUserIndexPattern = async ({ esClient, soClient }: Deps): Promise<boolean> => {
	const indexPatterns = await soClient.find<IndexPatternSavedObjectAttrs>({
	type: 'index-pattern',
	fields: ['title'],
	search: `*`,
	searchFields: ['title'],
	perPage: 100,
	});
	if (indexPatterns.total === 0) {
	return false;
	}
	// If there are any index patterns that are not the default metrics-* and logs-* ones created by Fleet,
	// assume there are user created index patterns
	if (
	indexPatterns.saved_objects.some(
	(ip) =>
	ip.attributes.title !== DEFAULT_ASSETS_TO_IGNORE.METRICS_INDEX_PATTERN &&
	ip.attributes.title !== DEFAULT_ASSETS_TO_IGNORE.LOGS_INDEX_PATTERN
	)
	) {
	return true;
	}
	const resolveResponse = await esClient.indices.resolveIndex({
	name: `${DEFAULT_ASSETS_TO_IGNORE.LOGS_INDEX_PATTERN},${DEFAULT_ASSETS_TO_IGNORE.METRICS_INDEX_PATTERN}`,
	});
	const hasAnyNonDefaultFleetIndices = resolveResponse.indices.some(
	(ds) => ds.name !== DEFAULT_ASSETS_TO_IGNORE.METRICS_ENDPOINT_INDEX_TO_IGNORE
	);
	if (hasAnyNonDefaultFleetIndices) return true;
	const hasAnyNonDefaultFleetDataStreams = resolveResponse.data_streams.some(
	(ds) =>
	ds.name !== DEFAULT_ASSETS_TO_IGNORE.METRICS_DATA_STREAM_TO_IGNORE &&
	ds.name !== DEFAULT_ASSETS_TO_IGNORE.LOGS_DATA_STREAM_TO_IGNORE &&
	ds.name !== DEFAULT_ASSETS_TO_IGNORE.ENT_SEARCH_LOGS_DATA_STREAM_TO_IGNORE
	);
	if (hasAnyNonDefaultFleetDataStreams) return true;
	return false;
	};

kibana/src/plugins/data_view_editor/public/components/empty_prompts/empty_prompts.tsx

Lines 32 to 46 in ade7177

	export function isUserDataIndex(source: MatchedItem) {
	// filter out indices that start with `.`
	if (source.name.startsWith('.')) return false;
	// filter out sources from DEFAULT_ASSETS_TO_IGNORE
	if (source.name === DEFAULT_ASSETS_TO_IGNORE.LOGS_DATA_STREAM_TO_IGNORE) return false;
	if (source.name === DEFAULT_ASSETS_TO_IGNORE.METRICS_DATA_STREAM_TO_IGNORE) return false;
	if (source.name === DEFAULT_ASSETS_TO_IGNORE.METRICS_ENDPOINT_INDEX_TO_IGNORE) return false;
	if (source.name === DEFAULT_ASSETS_TO_IGNORE.ENT_SEARCH_LOGS_DATA_STREAM_TO_IGNORE) return false;
	// filter out empty sources created by apm server
	if (source.name.startsWith('apm-')) return false;
	return true;
	}

Related issues:

#124019

cc @shivindera @mattkime

[elasticmachine]

Pinging @elastic/kibana-app-services (Team:AppServicesSv)