Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting/Dashboard] Newly loaded Sample Data dashboard must be explicitly saved before user can copy POST URL #117960

Closed
tsullivan opened this issue Nov 8, 2021 · 2 comments · Fixed by #121241
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@tsullivan
Copy link
Member

Kibana version: 7.16.0-SNAPSHOT

Describe the bug:
User incorrectly sees a message that the POST URL is too long and is unable to be copied.
Screenshot from 2021-11-02 16-43-21

Steps to reproduce:

  1. Install the flights dataset of sample data
  2. Once install is complete, click "Dashboard": https://user-images.githubusercontent.com/908371/140835590-dc393936-79ce-49a8-99cd-c6cccabeef11.png
  3. Click "Share" > "PDF Reports" > "Advanced options"

Expected behavior:
User should see a blue "Copy POST URL" button

There seems to be a workaround: after clicking Edit > Save, the correct behavior takes over and the user can click the "Copy POST URL" button.

Notes
As of this PR: #114331 the URL of a "saved" dashboard should never be too long to copy. Perhaps something about the way the dashboard is loaded makes the workaround needed.

@tsullivan tsullivan added the bug Fixes for quality problems that affect the customer experience label Nov 8, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 8, 2021
@tsullivan tsullivan added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Nov 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 8, 2021
@tsullivan tsullivan added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Nov 9, 2021
@tsullivan
Copy link
Member Author

@jloleysens and I chatted with @ThomThomson and we now understand the impact of this bug. It is very low impact, as it only affects the sample data dashboards.

It shouldn’t be possible for this to show up in a user’s dashboard. The reason the demo data is like this is because the map was saved into the dashboard without a mapBuffer which is because the saved object was manually written a while ago and hasn’t been subjected to migrations. That means that the entire panels part of the dashboard state is getting into the URL, which could definitely make it bigger than 25k characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants