Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOC integration tests - add assertions for redacted namespaces #112455

Open
jportner opened this issue Sep 16, 2021 · 3 comments
Open

SOC integration tests - add assertions for redacted namespaces #112455

jportner opened this issue Sep 16, 2021 · 3 comments
Labels
chore Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@jportner
Copy link
Contributor

jportner commented Sep 16, 2021

All of the security_and_spaces SavedObjectsClient API integration tests should include assertions for redacted namespaces.
The current status:

  • bulk_create
  • bulk_get
  • bulk_resolve
  • bulk_update
  • create
  • delete N/A (empty object)
  • export N/A (response doesn't include namespaces)
  • find
  • get
  • import N/A (response doesn't include namespaces)
  • resolve_import_errors N/A (response doesn't include namespaces)
  • resolve
  • update

It's worth noting that the existing assertions are a bit of a hack (because they are programmatically generated) and we should consider improving those too.

@jportner jportner added chore Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! labels Sep 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Sep 29, 2021
@legrego legrego removed loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Aug 22, 2022
@legrego
Copy link
Member

legrego commented Jan 13, 2023

@jeramysoucy, do you happen to know if this is still accurate? Have your recent improvements resolved this, or is it still an open issue?

@jeramysoucy
Copy link
Contributor

@jeramysoucy, do you happen to know if this is still accurate? Have your recent improvements resolved this, or is it still an open issue?

@legrego this is still an open issue. I haven't made any modifications to the API integration tests (very much on purpose, as they were my gold standard for making sure my changes didn't break anything).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

No branches or pull requests

4 participants