You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All of the security_and_spaces SavedObjectsClient API integration tests should include assertions for redacted namespaces.
The current status:
bulk_create ✅
bulk_get ❌
bulk_resolve ❌
bulk_update ❌
create ✅
delete N/A (empty object)
export N/A (response doesn't include namespaces)
find ✅
get ❌
import N/A (response doesn't include namespaces)
resolve_import_errors N/A (response doesn't include namespaces)
resolve ❌
update ❌
It's worth noting that the existing assertions are a bit of a hack (because they are programmatically generated) and we should consider improving those too.
The text was updated successfully, but these errors were encountered:
legrego
removed
loe:small
Small Level of Effort
impact:low
Addressing this issue will have a low level of impact on the quality/strength of our product.
labels
Aug 22, 2022
@jeramysoucy, do you happen to know if this is still accurate? Have your recent improvements resolved this, or is it still an open issue?
@legrego this is still an open issue. I haven't made any modifications to the API integration tests (very much on purpose, as they were my gold standard for making sure my changes didn't break anything).
All of the
security_and_spaces
SavedObjectsClient API integration tests should include assertions for redacted namespaces.The current status:
bulk_create
✅bulk_get
❌bulk_resolve
❌bulk_update
❌create
✅delete
N/A (empty object)export
N/A (response doesn't include namespaces)find
✅get
❌import
N/A (response doesn't include namespaces)resolve_import_errors
N/A (response doesn't include namespaces)resolve
❌update
❌It's worth noting that the existing assertions are a bit of a hack (because they are programmatically generated) and we should consider improving those too.
The text was updated successfully, but these errors were encountered: