From ea796258ecf6b64eac1e2b5bb293829be5560ac8 Mon Sep 17 00:00:00 2001
From: liza-mae <liza.dayoub@elastic.co>
Date: Thu, 21 Nov 2019 16:07:07 -0700
Subject: [PATCH] Add wait for chart to render and fix time picker

---
 .../page_objects/infra_home_page.ts           |  9 ++++++++
 .../tests/infra/saved_views.js                | 21 +++++++++----------
 2 files changed, 19 insertions(+), 11 deletions(-)

diff --git a/x-pack/test/functional/page_objects/infra_home_page.ts b/x-pack/test/functional/page_objects/infra_home_page.ts
index 998a60500aca2..160a2cf61b671 100644
--- a/x-pack/test/functional/page_objects/infra_home_page.ts
+++ b/x-pack/test/functional/page_objects/infra_home_page.ts
@@ -74,5 +74,14 @@ export function InfraHomePageProvider({ getService }: FtrProviderContext) {
       await testSubjects.click('configureSourceButton');
       await testSubjects.exists('sourceConfigurationFlyout');
     },
+
+    async waitForChartToLoad() {
+      await retry.try(async () => {
+        const renderComplete = await find.byCssSelector('[data-ech-render-complete="true"]');
+        if (! renderComplete ) {
+          throw new Error('Chart did not render');
+        }
+      });
+    },
   };
 }
diff --git a/x-pack/test/visual_regression/tests/infra/saved_views.js b/x-pack/test/visual_regression/tests/infra/saved_views.js
index 4a3be5216f651..0c7ec08731bc4 100644
--- a/x-pack/test/visual_regression/tests/infra/saved_views.js
+++ b/x-pack/test/visual_regression/tests/infra/saved_views.js
@@ -13,17 +13,16 @@ export default function ({ getPageObjects, getService }) {
   const find = getService('find');
 
   describe('saved views', () => {
-
-    before(async function () {
-      esArchiver.load('infra/metrics_and_logs');
-      await PageObjects.common.navigateToApp('infraOps');
-      await PageObjects.infraHome.goToTime(DATE_WITH_DATA);
-      await PageObjects.header.awaitGlobalLoadingIndicatorHidden();
-    });
-
+    before(() => esArchiver.load('infra/metrics_and_logs'));
     after(() => esArchiver.unload('infra/metrics_and_logs'));
 
     describe('Inventory Test save functionality', () => {
+      before(async function () {
+        await PageObjects.common.navigateToApp('infraOps');
+        await PageObjects.infraHome.goToTime(DATE_WITH_DATA);
+        await PageObjects.header.awaitGlobalLoadingIndicatorHidden();
+      });
+
       it('should have save and load controls', async () => {
         await PageObjects.infraHome.getSaveViewButton();
         await PageObjects.infraHome.getLoadViewsButton();
@@ -56,15 +55,15 @@ export default function ({ getPageObjects, getService }) {
     });
 
     describe('Metric Explorer Test save functionality', () => {
-
-      const fromTime = '2018-10-16 09:00:00.000';
-      const toTime = '2018-10-18 19:00:00.000';
+      const fromTime = 'Oct 16, 2018 @ 00:00:00.000';
+      const toTime =   'Oct 18, 2018 @ 00:00:00.000';
 
       before(async function () {
         await PageObjects.common.navigateToApp('infraOps');
         await PageObjects.infraHome.goToMetricExplorer();
         await PageObjects.timePicker.setAbsoluteRange(fromTime, toTime);
         await PageObjects.header.awaitGlobalLoadingIndicatorHidden();
+        await PageObjects.infraHome.waitForChartToLoad();
       });
 
       it('should have save and load controls', async () => {