Skip to content

Commit

Permalink
removed unnecessary changes
Browse files Browse the repository at this point in the history
  • Loading branch information
js-jankisalvi committed Aug 10, 2023
1 parent 6ec2f43 commit e5393ab
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
5 changes: 0 additions & 5 deletions test/functional/page_objects/dashboard_page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -468,16 +468,13 @@ export class DashboardPageObject extends FtrService {
await this.testSubjects.existOrFail('saveDashboardSuccess');
});
const message = await this.common.closeToast();

await this.header.waitUntilLoadingHasFinished();

await this.common.waitForSaveModalToClose();

const isInViewMode = await this.testSubjects.exists('dashboardEditMode');
if (saveOptions.exitFromEditMode && !isInViewMode) {
await this.clickCancelOutOfEditMode();
}

await this.header.waitUntilLoadingHasFinished();

return message;
Expand Down Expand Up @@ -568,9 +565,7 @@ export class DashboardPageObject extends FtrService {
await this.listingTable.searchForItemWithName(dashboardName);
await this.retry.try(async () => {
await this.listingTable.clickItemLink('dashboard', dashboardName);

await this.header.waitUntilLoadingHasFinished();

// check Dashboard landing page is not present
await this.testSubjects.missingOrFail('dashboardLandingPage', { timeout: 10000 });
});
Expand Down
2 changes: 0 additions & 2 deletions test/functional/services/dashboard/add_panel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,7 @@ export class DashboardAddPanelService extends FtrService {
await this.browser.pressKeys(this.browser.keys.ESCAPE);
await this.testSubjects.click('dashboardAddNewPanelButton');
await this.testSubjects.waitForDeleted('dashboardAddNewPanelButton');

await this.header.waitUntilLoadingHasFinished();

await this.testSubjects.existOrFail('lnsApp', {
timeout: 5000,
});
Expand Down

0 comments on commit e5393ab

Please sign in to comment.